[Impeller] remove entity pass and re-combine canvas implementations. #55019
+1,288
−5,420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into remove_entity_pass
…into remove_entity_pass
jonahwilliams
changed the title
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Golden file changes are available for triage from new commit, Click here to view. |
…into remove_entity_pass
…into remove_entity_pass
…into remove_entity_pass
chinmaygarde
approved these changes
Sep 26, 2024
| @@ -35,9 +35,6 @@ declare_args() { | |||
| # See [go/slimpeller-dashboard](https://github.com/orgs/flutter/projects/21) | |||
| # for details. | |||
| slimpeller = false | |||
|
|
|||
| # Opt into new DL dispatcher that skips AIKS layer | |||
| experimental_canvas = true | |||
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 27, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 27, 2024
…155799) flutter/engine@5351777...e57b440 2024-09-26 [email protected] Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55464) 2024-09-26 [email protected] [Impeller] remove entity pass and re-combine canvas implementations. (flutter/engine#55019) 2024-09-26 [email protected] Roll Skia from e986bd33fb33 to 9ebb7c3640a1 (3 revisions) (flutter/engine#55466) 2024-09-26 [email protected] Roll Skia from 5f6ea5ff8401 to e986bd33fb33 (1 revision) (flutter/engine#55465) 2024-09-26 [email protected] Remove and inline dependencies on `build_root` for a constant. (flutter/engine#55441) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (#55418)" (#55450)" (flutter/engine#55463) 2024-09-26 [email protected] cipd: add mobileprovision CIPD package (flutter/engine#55449) 2024-09-26 [email protected] Roll Skia from b2c5f640cb44 to 5f6ea5ff8401 (1 revision) (flutter/engine#55462) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shouldn't land until experimental canvas bakes a while
Major milestone along the route to making display list the impeller API. Removes the secondary compositor in entity pass. After this point, we can begin ripping out the DL->Aiks conversions and making entities more efficient.
Fixes flutter/flutter#132417
Fixes flutter/flutter#126386
Fixes flutter/flutter#155114
Part of flutter/flutter#142054