Skip to content

Commit

Permalink
Move lint suppression from baseline.xml to @SuppressLint. (#55447)
Browse files Browse the repository at this point in the history
I think you just had the lint identifier wrong?

Closes flutter/flutter#155712.
  • Loading branch information
matanlurey authored Sep 25, 2024
1 parent 62c0e50 commit f7668af
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,7 @@ private int guessBottomKeyboardInset(WindowInsets insets) {
// The annotations to suppress "InlinedApi" and "NewApi" lints prevent lint warnings
// caused by usage of Android Q APIs. These calls are safe because they are
// guarded.
@SuppressLint({"InlinedApi", "NewApi"})
@SuppressLint({"InlinedApi", "NewApi", "DeprecatedSinceApi"})
@NonNull
public final WindowInsets onApplyWindowInsets(@NonNull WindowInsets insets) {
WindowInsets newInsets = super.onApplyWindowInsets(insets);
Expand Down
11 changes: 0 additions & 11 deletions tools/android_lint/baseline.xml
Original file line number Diff line number Diff line change
@@ -1,17 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.3.0 [11479570] " type="baseline" client="" dependencies="true" name="" variant="all" version="8.3.0 [11479570] ">

<issue
id="DeprecatedSinceApi"
message="This method is deprecated as of API level 30"
errorLine1=" zeroSides = calculateShouldZeroSides();"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterView.java"
line="759"
column="21"/>
</issue>

<issue
id="HardcodedDebugMode"
message="Avoid hardcoding the debug mode; leaving it out allows debug and release builds to automatically assign one"
Expand Down

0 comments on commit f7668af

Please sign in to comment.