Adding the basis for the Logging v2 experience #7724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderDake
commented
May 9, 2024
packages/devtools_app/lib/src/screens/logging/logging_screen_v2/logging_screen_v2.dart
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/logging/logging_screen_v2/logging_screen_v2.dart
Show resolved
Hide resolved
packages/devtools_app/test/logging/logging_screen_v2/logging_controller_v2_test.dart
Show resolved
Hide resolved
packages/devtools_app/test/logging/logging_screen_v2/logging_screen_v2_test.dart
Show resolved
Hide resolved
CoderDake
changed the title
|
I made another version that just copies the controller and screen over, so this PR will be more simple. |
CoderDake
commented
May 10, 2024
packages/devtools_app/lib/src/screens/logging/logging_screen_v2/logging_controller_v2.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/logging/logging_screen_v2/logging_controller_v2.dart
Outdated
Show resolved
Hide resolved
| Row( | ||
| children: [ | ||
| Expanded( | ||
| child: TextField( |
There was a problem hiding this comment.
use DevToolsClearableTextField for both of these. Fine to implement functionality later
There was a problem hiding this comment.
I'll implement this in the next one.
| with | ||
| AutoDisposeMixin, | ||
| ProvidedControllerMixin<LoggingControllerV2, LoggingScreenBody> { | ||
| ProvidedControllerMixin<LoggingControllerV2, LoggingScreenBodyV2> { | ||
| List<String> items = []; |
There was a problem hiding this comment.
nit: logs instead of items
There was a problem hiding this comment.
This will be part of upcoming changes.
packages/devtools_app/lib/src/screens/logging/logging_screen_v2/logging_screen_v2.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/test/logging/logging_screen_v2/logging_controller_v2_test.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/test/logging/logging_screen_v2/logging_controller_v2_test.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/test/logging/logging_screen_v2/logging_screen_v2_test.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied and modified the logging screen and logging controller files.
This changes is just meant to establish the main points so we can build each of the components in the next PRs.