Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization for diff and profile tabs. #7699

Merged
merged 40 commits into from May 20, 2024
Merged

Serialization for diff and profile tabs. #7699

merged 40 commits into from May 20, 2024

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented May 5, 2024

No description provided.

@polina-c
Squashed commit of the following:
f167213 
commit 82c3677
Merge: 37843f3 9e7a0fa
Author: Polina Cherkasova <[email protected]>
Date:   Sat May 4 20:21:21 2024 -0700

    Merge branch 'master' of github.com:flutter/devtools into profile2

commit 37843f3
Author: Polina Cherkasova <[email protected]>
Date:   Thu May 2 15:12:55 2024 -0700

    Update chart_connection.dart

commit 041a5eb
Author: Polina Cherkasova <[email protected]>
Date:   Thu May 2 15:12:09 2024 -0700

    Update chart_connection.dart

commit 192d438
Author: Polina Cherkasova <[email protected]>
Date:   Thu May 2 15:08:01 2024 -0700

    Update default.dart

commit 088ab9b
Author: Polina Cherkasova <[email protected]>
Date:   Thu May 2 15:07:17 2024 -0700

    -

commit 564233e
Author: Polina Cherkasova <[email protected]>
Date:   Thu May 2 14:05:30 2024 -0700

    Update profile_pane_controller.dart

commit fada247
Merge: e60d40b 6932cc3
Author: Polina Cherkasova <[email protected]>
Date:   Thu May 2 14:04:59 2024 -0700

    Merge branch 'profile1' into profile2

commit 6932cc3
Author: Polina Cherkasova <[email protected]>
Date:   Thu May 2 13:21:34 2024 -0700

    -

commit f22bc4a
Author: Polina Cherkasova <[email protected]>
Date:   Thu May 2 12:22:40 2024 -0700

    -

commit 7f45b3a
Author: Polina Cherkasova <[email protected]>
Date:   Thu May 2 10:44:17 2024 -0700

    Update memory_controller.dart

commit 3a4d29a
Merge: 4b39a30 6f3989f
Author: Polina Cherkasova <[email protected]>
Date:   Wed May 1 15:24:31 2024 -0700

    Merge branch 'master' of github.com:flutter/devtools into profile1

commit 4b39a30
Author: Polina Cherkasova <[email protected]>
Date:   Wed May 1 15:21:27 2024 -0700

    -

commit 3bec7b5
Author: Polina Cherkasova <[email protected]>
Date:   Wed May 1 15:16:15 2024 -0700

    k2

commit 7b05c33
Author: Polina Cherkasova <[email protected]>
Date:   Wed May 1 15:02:44 2024 -0700

    k1

commit e60d40b
Author: Polina Cherkasova <[email protected]>
Date:   Wed May 1 14:31:12 2024 -0700

    -

commit 448c7d0
Author: Polina Cherkasova <[email protected]>
Date:   Wed May 1 13:37:26 2024 -0700

    Update snapshot_item.dart

commit 5806c2f
Merge: a614c58 4caa78c
Author: Polina Cherkasova <[email protected]>
Date:   Wed May 1 13:15:01 2024 -0700

    Merge branch 'profile1' into profile2

commit 4caa78c
Author: Polina Cherkasova <[email protected]>
Date:   Wed May 1 10:46:46 2024 -0700

    Update chart_connection.dart

commit b255be6
Author: Polina Cherkasova <[email protected]>
Date:   Wed May 1 10:46:06 2024 -0700

    Update chart_connection.dart

commit fea1d0c
Author: Polina Cherkasova <[email protected]>
Date:   Wed May 1 10:42:17 2024 -0700

    -

commit 7ec0aab
Author: Polina Cherkasova <[email protected]>
Date:   Wed May 1 09:32:12 2024 -0700

    -

commit 69e6c57
Author: Polina Cherkasova <[email protected]>
Date:   Wed May 1 09:30:55 2024 -0700

    -

commit 9f52f81
Author: Polina Cherkasova <[email protected]>
Date:   Wed May 1 08:33:56 2024 -0700

    Update chart_pane_controller.dart

commit a614c58
Merge: 7b560c5 f132615
Author: Polina Cherkasova <[email protected]>
Date:   Wed May 1 08:29:21 2024 -0700

    Merge branch 'profile1' into profile2

commit f132615
Author: Polina Cherkasova <[email protected]>
Date:   Wed May 1 08:28:12 2024 -0700

    Update chart_pane_controller.dart

commit 4fc2ff6
Merge: dac5ec2 cf969fc
Author: Polina Cherkasova <[email protected]>
Date:   Wed May 1 08:18:20 2024 -0700

    Merge branch 'master' of github.com:flutter/devtools into profile1

commit dac5ec2
Author: Polina Cherkasova <[email protected]>
Date:   Tue Apr 30 15:14:04 2024 -0700

    Update chart_data.dart

commit bec346c
Author: Polina Cherkasova <[email protected]>
Date:   Tue Apr 30 15:00:21 2024 -0700

    -

commit e18340b
Author: Polina Cherkasova <[email protected]>
Date:   Tue Apr 30 14:45:31 2024 -0700

    -

commit 7094095
Author: Polina Cherkasova <[email protected]>
Date:   Tue Apr 30 14:01:24 2024 -0700

    -

commit 2eea0ac
Author: Polina Cherkasova <[email protected]>
Date:   Tue Apr 30 08:07:06 2024 -0700

    -

commit 8cd4cf6
Author: Polina Cherkasova <[email protected]>
Date:   Mon Apr 29 13:30:52 2024 -0700

    Update chart_connection.dart

commit 0150b54
Author: Polina Cherkasova <[email protected]>
Date:   Mon Apr 29 13:21:59 2024 -0700

    Update chart_connection.dart

commit 3588189
Author: Polina Cherkasova <[email protected]>
Date:   Mon Apr 29 13:13:35 2024 -0700

    Update chart_connection.dart

commit 3016324
Author: Polina Cherkasova <[email protected]>
Date:   Mon Apr 29 12:59:33 2024 -0700

    Update chart_connection.dart

commit 6f1dd10
Author: Polina Cherkasova <[email protected]>
Date:   Mon Apr 29 12:44:37 2024 -0700

    -

commit 7b560c5
Author: Polina Cherkasova <[email protected]>
Date:   Mon Apr 29 10:16:20 2024 -0700

    Update diff_pane_controller.dart

commit e21cb05
Author: Polina Cherkasova <[email protected]>
Date:   Sun Apr 28 14:52:41 2024 -0700

    -

commit 5a30bc4
Merge: 26b3560 0f34068
Author: Polina Cherkasova <[email protected]>
Date:   Sun Apr 28 14:51:48 2024 -0700

    Merge branch 'master' of github.com:flutter/devtools into profile2

commit 26b3560
Author: Polina Cherkasova <[email protected]>
Date:   Sat Apr 27 17:37:25 2024 -0700

    Update profile_pane_controller.dart

commit 7fb2681
Author: Polina Cherkasova <[email protected]>
Date:   Sat Apr 27 16:16:02 2024 -0700

    Update diff_pane_controller.dart

commit 983fa7b
Author: Polina Cherkasova <[email protected]>
Date:   Sat Apr 27 15:44:17 2024 -0700

    -

commit e91c289
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 26 16:34:03 2024 -0700

    Update profile_pane_controller.dart

commit 980af0d
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 26 15:02:53 2024 -0700

    -

commit fc6577a
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 26 14:51:44 2024 -0700

    Update chart_connection.dart

commit 18d8ca8
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 26 14:40:26 2024 -0700

    Update chart_connection.dart

commit ff2c13e
Merge: 6d30b8c 666c67d
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 26 12:30:36 2024 -0700

    Merge branch 'master' of github.com:flutter/devtools into profile1

commit 6d30b8c
Merge: 27feae4 02f08e6
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 26 11:34:15 2024 -0700

    Merge branch 'move' into profile1

commit 02f08e6
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 26 11:32:27 2024 -0700

    -

commit 364897d
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 26 10:24:18 2024 -0700

    Update memory_screen_test.dart

commit 27feae4
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 26 10:21:04 2024 -0700

    Update memory_screen_test.dart

commit dc0f7ab
Merge: 82717ab 4b36dcd
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 26 10:14:02 2024 -0700

    Merge branch 'move' into profile1

commit 4b36dcd
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 26 10:13:05 2024 -0700

    Update memory_screen_test.dart

commit 6c4ee49
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 26 09:33:15 2024 -0700

    -

commit 6c247d4
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 26 08:55:51 2024 -0700

    Update legend.dart

commit ec79211
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 26 08:36:38 2024 -0700

    -

commit 82717ab
Merge: bbbe855 67465cd
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 26 08:19:46 2024 -0700

    Merge branch 'move' into profile1

commit 67465cd
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 26 08:18:26 2024 -0700

    Update vm_developer_common_widgets_test.dart

commit 0a01970
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 22:01:18 2024 -0700

    Update vm_developer_common_widgets_test.dart

commit b24b938
Merge: 1783728 e15c472
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 21:56:04 2024 -0700

    Merge branch 'move' of github.com:polina-c/devtools; branch 'master' of github.com:flutter/devtools into move

commit bbbe855
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 21:55:21 2024 -0700

    -

commit d8a61c5
Merge: a1e0759 1783728
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 21:37:44 2024 -0700

    Merge branch 'move' into profile1

commit 1783728
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 17:18:05 2024 -0700

    Update memory_timeline.dart

commit a1e0759
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 16:57:03 2024 -0700

    -

commit d1c4c14
Merge: a3cdb0d 7af2302
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 16:56:11 2024 -0700

    Merge branch 'move' into profile1

commit a3cdb0d
Merge: 4085f2a e15c472
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 16:32:54 2024 -0700

    Merge branch 'master' of github.com:flutter/devtools into profile1

commit 7af2302
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 16:28:51 2024 -0700

    Update event_chart_controller.dart

commit 2db214b
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 16:17:29 2024 -0700

    Update memory_chart.dart

commit 02c2c06
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 16:15:11 2024 -0700

    -

commit fc42147
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 16:02:58 2024 -0700

    -

commit f669e2a
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 16:02:10 2024 -0700

    -

commit 1c48245
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 16:02:03 2024 -0700

    -

commit 8ba09a6
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 15:51:20 2024 -0700

    Update events_chart.dart

commit d2843af
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 15:43:35 2024 -0700

    Update events_chart.dart

commit 0a9a4be
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 15:41:53 2024 -0700

    -

commit 5fac57d
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 15:41:11 2024 -0700

    -

commit 7662210
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 15:27:32 2024 -0700

    -

commit 7f7f68e
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 15:15:47 2024 -0700

    -

commit d4ec16a
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 15:12:02 2024 -0700

    -

commit f3d089a
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 14:48:16 2024 -0700

    -

commit 28413fe
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 14:35:36 2024 -0700

    Update vm_chart_controller.dart

commit 08cc3d8
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 14:32:20 2024 -0700

    Update vm_chart.dart

commit df8b8d2
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 14:30:25 2024 -0700

    -

commit cc11ea7
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 14:24:37 2024 -0700

    Update vm_chart_controller.dart

commit 7dbb3e2
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 14:23:51 2024 -0700

    -

commit 6eb8409
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 14:19:21 2024 -0700

    Update vm_chart.dart

commit 6318170
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 14:16:48 2024 -0700

    -

commit aa90de3
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 14:03:47 2024 -0700

    -

commit 5054ea9
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 13:49:34 2024 -0700

    -

commit a8e4ac0
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 13:44:37 2024 -0700

    -

commit 4085f2a
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 25 12:43:38 2024 -0700

    Update chart_pane_controller.dart

commit bb82f00
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 24 17:43:12 2024 -0700

    Update offline_data.dart

commit 98ec6a4
Merge: 7946b77 585b55f
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 24 17:41:22 2024 -0700

    Merge branch 'master' of github.com:flutter/devtools into profile1

commit 7946b77
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 24 17:40:23 2024 -0700

    -

commit 6c86e1f
Merge: 29d3c63 a297a05
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 24 15:03:00 2024 -0700

    Merge branch 'master' of github.com:flutter/devtools into profile1

commit 29d3c63
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 24 15:02:27 2024 -0700

    Update memory_controller.dart

commit 6fd13c4
Merge: 47b29b1 3116379
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 24 15:00:50 2024 -0700

    Merge branch 'refactor' into profile1

commit 3116379
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 24 14:59:20 2024 -0700

    -

commit 47b29b1
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 24 14:52:56 2024 -0700

    -

commit dc7f26a
Merge: edc00b1 1a8d8ab
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 24 14:49:28 2024 -0700

    Merge branch 'master' of github.com:flutter/devtools into profile1

commit edc00b1
Merge: 864f5d1 d84fdf3
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 24 14:49:03 2024 -0700

    Merge branch 'refactor' into profile1

commit d84fdf3
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 24 14:34:06 2024 -0700

    -

commit e0ae211
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 24 14:12:11 2024 -0700

    -

commit 864f5d1
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 24 14:02:20 2024 -0700

    -

commit 0f42342
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 24 12:56:36 2024 -0700

    -

commit 2b2106b
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 24 11:27:49 2024 -0700

    -

commit d78f710
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 24 11:09:37 2024 -0700

    Update chart_pane_controller.dart

commit d6ab8f0
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 24 11:07:13 2024 -0700

    Update memory_timeline.dart

commit bdba538
Author: Polina Cherkasova <[email protected]>
Date:   Tue Apr 23 16:05:09 2024 -0700

    -

commit 33e06dd
Author: Polina Cherkasova <[email protected]>
Date:   Tue Apr 23 15:34:50 2024 -0700

    -

commit c8ed523
Author: Polina Cherkasova <[email protected]>
Date:   Mon Apr 22 16:41:41 2024 -0700

    -

commit d43f02e
Merge: f40c377 7fb09d5
Author: Polina Cherkasova <[email protected]>
Date:   Mon Apr 22 16:39:20 2024 -0700

    Merge branch 'master' of github.com:flutter/devtools into profile1

commit f40c377
Author: Polina Cherkasova <[email protected]>
Date:   Sun Apr 21 15:53:50 2024 -0700

    -

commit eed9879
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 19 21:58:17 2024 -0700

    Update gc_stats.dart

commit 8e8af7a
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 19 21:53:53 2024 -0700

    Update gc_stats.dart

commit c7a23bf
Merge: 82564bc e4a4efa
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 19 21:53:17 2024 -0700

    Merge branch 'gc-stats' into profile1

commit e4a4efa
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 19 21:44:17 2024 -0700

    -

commit 82564bc
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 19 16:52:18 2024 -0700

    -

commit 69fdb05
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 19 16:23:42 2024 -0700

    -

commit df746cc
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 19 16:05:21 2024 -0700

    -

commit 46a64a0
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 19 15:48:12 2024 -0700

    -

commit e9ac83b
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 19 15:22:00 2024 -0700

    -

commit f6b83fd
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 19 15:06:10 2024 -0700

    -

commit 8dfbf50
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 19 12:27:01 2024 -0700

    -

commit bbaf14e
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 19 12:10:33 2024 -0700

    Update profile_pane_controller.dart

commit c28413e
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 19 12:06:05 2024 -0700

    Update profile_pane_controller.dart

commit 8a3b629
Author: Polina Cherkasova <[email protected]>
Date:   Fri Apr 19 12:05:32 2024 -0700

    -

commit 396ce7f
Merge: c60b98e 8327c5e
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 18 08:41:22 2024 -0700

    Merge branch 'master' of github.com:flutter/devtools into profile1

commit c60b98e
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 18 08:35:07 2024 -0700

    -

commit 25741df
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 18 08:28:38 2024 -0700

    Update profile_pane_controller.dart

commit 3f33dd0
Author: Polina Cherkasova <[email protected]>
Date:   Thu Apr 18 07:13:20 2024 -0700

    Update profile_pane_controller.dart

commit 8684c58
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 17 18:27:45 2024 -0700

    -

commit 756e46e
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 17 18:11:14 2024 -0700

    -

commit eddaa1f
Merge: b35d993 b7a3d73
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 17 16:49:58 2024 -0700

    Merge branch 'master' of github.com:flutter/devtools into profile1

commit b35d993
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 17 15:30:45 2024 -0700

    Update model.dart

commit 7eca578
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 17 15:13:59 2024 -0700

    Update model.dart

commit c004a97
Author: Polina Cherkasova <[email protected]>
Date:   Wed Apr 17 14:59:50 2024 -0700

    -
@polina-c polina-c marked this pull request as ready for review May 7, 2024 17:25
@polina-c polina-c requested review from bkonyi and a team as code owners May 7, 2024 17:25
@polina-c polina-c changed the title Offline mode Serialization for diff and profile tabs. May 7, 2024
kenzieschmoll
kenzieschmoll reviewed May 7, 2024
View reviewed changes
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for the new serialization and any other affected code as part of this change.

packages/devtools_shared/lib/src/memory/event_sample.dart Outdated Show resolved Hide resolved
packages/devtools_app/test/memory/framework/memory_controller_test.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/screens/memory/panes/diff/controller/diff_pane_controller.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/screens/memory/panes/diff/controller/diff_pane_controller.dart Show resolved Hide resolved
packages/devtools_app/lib/src/screens/memory/panes/diff/controller/diff_pane_controller.dart Show resolved Hide resolved
packages/devtools_app/lib/src/screens/memory/panes/diff/controller/snapshot_item.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/screens/memory/panes/profile/profile_view.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/screens/memory/panes/diff/controller/diff_pane_controller.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/shared/memory/heap_graph_loader.dart Show resolved Hide resolved
packages/devtools_app/lib/src/shared/memory/heap_data.dart Outdated Show resolved Hide resolved
@polina-c
Copy link
Contributor Author

polina-c commented May 9, 2024

Please add tests for the new serialization and any other affected code as part of this change.

Added tests for serialization.
Most of other code is test covered.

I will add more coverage after completing the feature and before removing the flag.

kenzieschmoll
kenzieschmoll reviewed May 20, 2024
View reviewed changes
packages/devtools_app/lib/src/screens/memory/panes/chart/controller/chart_data.dart Outdated
Comment on lines 16 to 18
timeline('timeline'),
interval('interval'),
isLegendVisible('isLegendVisible');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of passing the string representation to each of these, consider this pattern where the constructor has an optional name override, and then you don't have to pass in the string for the values where Json.enumValue.name is the equivalent.

example: https://github.com/flutter/devtools/blob/master/packages/devtools_app/integration_test/test_infra/run/_test_app_driver.dart/#L417

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024
@auto-submit Auto-submit
Copy link

auto-submit bot commented May 20, 2024

auto label is removed for flutter/devtools/7699, due to - The status or check suite devtools_shared test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024
@auto-submit Auto-submit
Copy link

auto-submit bot commented May 20, 2024

auto label is removed for flutter/devtools/7699, due to - The status or check suite devtools_app integration-test integration_dart2js - flutter - shard 2/3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c
-
f166ab6 
This reverts commit 43f7c07.
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024
@auto-submit auto-submit bot merged commit 1aa6db6 into flutter:master May 20, 2024
24 checks passed
@polina-c polina-c deleted the offline1 branch May 20, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@bkonyi bkonyi Awaiting requested review from bkonyi bkonyi is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App release-notes-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@polina-c @kenzieschmoll