Convert relative site URLs in release notes #7529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Have you verified that the markdown viewer in DevTools still works as expected? (for both the local debugging case and for loading notes from the flutter website in production)? You can click the release notes button here to trigger opening the viewer: |
|
Sorry about the delay, forgot to return to this. Yes, I've tried these latest changes out with a local debugging instance and the production site. |
packages/devtools_app/lib/src/framework/release_notes/release_notes.dart
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer use
{{site.url}}in Markdown files on the site to enable easier contributing, so{{site.url}}doesn't work as a replacement target anymore. Instead the site-relative image links are formatted as. Same goes for other non-image links.For DevTools to handle this case, this PR uses a regex to recognize Markdown link format to insert the docs site URL or the current debug URL. I used
replaceAllMappedover lookahead/lookbehind assertions due to browser support still being limited.