Add navigation support to the object inspector #5206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for navigating back/forward using the browser's back/forward buttons. This change also updates DevToolsRouterDelegate to keep track of its own navigation history, allowing for history navigation for non-browser targets in the future.
...ges/devtools_app/lib/src/screens/vm_developer/object_inspector/class_hierarchy_explorer.dart
Outdated
Show resolved
Hide resolved
|
I checked with @bkonyi and confirmed that this is still on their radar. |
|
Picking this back up, but there's been some regressions in the router behavior that need to be resolved before this change can be verified and made ready to land (see flutter/flutter#130433). |
|
Strange router behavior reported in flutter/flutter#130433 has been fixed and was able to verify this change works correctly in Chrome. @kenzieschmoll, this is ready for another review. |
|
I checked with @bkonyi and confirmed that this is still on their radar as of September 20th. |
|
(triage) I spoke to @bkonyi and he says this is still on his radar ... eventually. |
|
(triage): Spoke to @bkonyi last week and he promised to get back to this before he retires. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for navigating back/forward using the browser's back/forward buttons.
This change also updates DevToolsRouterDelegate to keep track of its own navigation history, allowing for history navigation for non-browser targets in the future.
RELEASE_NOTE_EXCEPTION=VM developer mode feature