Frontend support for firestore migration #3666
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyonghan
force-pushed
the
frontend_firestore
branch
from
ba86c47
to
f8797fe
Compare
keyonghan
commented
Apr 18, 2024
Comment on lines
+14
to
+25
| /// This is a side effect after deprecating `stage` field from Task model. A | ||
| /// more generic way to detect dart internal targets may be preferred. | ||
| const Set<String> dartInternalTasks = <String>{ | ||
| 'Linux engine_release_builder', | ||
| 'Linux flutter_release', | ||
| 'Linux flutter_release_builder', | ||
| 'Linux packaging_release_builder', | ||
| 'Mac engine_release_builder', | ||
| 'Mac packaging_release_builder', | ||
| 'Windows engine_release_builder', | ||
| 'Windows packaging_release_builder', | ||
| }; |
There was a problem hiding this comment.
@godofredoc Do we expect to have more dart internal tasks? I have been thinking about whether it deserves the effort to add a new Task field to identify these targets, similar to the old stage. If these targets are relatively steady, then a list like this may be enough. Or is there a pattern I can use here to determine whether a target is from dart-internal? like *flutter_release*/*engine_release*/*packaging_release*?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.