Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firestore data model protos #3632

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Conversation

keyonghan
Copy link
Contributor

@keyonghan keyonghan commented Apr 8, 2024

This is to prepare frontend firestore migration for Cocoon dashboard.

Part of flutter/flutter#142951.
One can view #3619 for a quick reference how we are gonna to use these protos.

This PR adds:

  • commit_firestore.proto, a replacement of commit.proto for Datastore case
  • task_firestore.proto, a replacement of task.proto for Datastore case
  • commit_tasks_status.proto, a replacement of commit_status.proto for Datastore case

Note: *.pb.dart, *.pbenum.dart, *.pbjson.dart, *.pbserver.dart are auto generated based on the proto.

@keyonghan
Copy link
Contributor Author

A friendly ping in case this falls off your plates:-)
Rest assured, this is an no-op change.

@ricardoamador
Copy link
Contributor

Do you mean you will wait to merge this in? :)

Copy link
Contributor

@ricardoamador ricardoamador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyonghan
Copy link
Contributor Author

Do you mean you will wait to merge this in? :)

Do you need me to wait? This is a no-op, and you do not need to rebase on top of these changes.

@keyonghan keyonghan added the autosubmit Merge PR when tree becomes green via auto submit App. label Apr 10, 2024
@auto-submit auto-submit bot merged commit 9ccd1e7 into flutter:main Apr 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
2 participants