Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add placeholder, placeholderStyle to FormBuilderCupertinoTextField #8

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

CyMathew
Copy link
Contributor

@CyMathew CyMathew commented Oct 6, 2023

Connection with issue(s)

Close #7

Solution description

Added optional placeholder and placeholderStyle to FormBuilderCupertinoTextField, so now users can add placeholder if they'd like

Screenshots or Videos

Screenshot 2023-10-06 at 4 34 42 PM

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour Difficult to test placeholder text
  • If apply, add documentation to code properties and package readme

@deandreamatias
Copy link
Contributor

Thanks a lot for this contribution and sorry for delay merge. I lost the notification on all others.

@deandreamatias deandreamatias merged commit e911357 into flutter-form-builder-ecosystem:main Jun 8, 2024
1 check passed
@florisdipt
Copy link

@deandreamatias Can we get a new version release on pub.dev? Last one was from last year and its a shame to have development time put in to things that are not available there :)
Also because of #14 not being on pub.dev it is incompatible with newer flutter versions.

@deandreamatias
Copy link
Contributor

@florisdipt Anyone can create PR with a commit (like this) to generate version and then I can push a tag. With this, automatically is pushed new version to pub.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FormBuilderCupertinoTextField]: Add placeholder option
3 participants