-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add remaing Filament weight in Printer Status #460
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you post a screenshot of this working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending @pedrolamas review.
I'm just checking this now, first comment I have is that personally I'm not very fond of that line break that screws the label alignment on the left as it shows on your screenshot! I wonder if it wouldn't be more practical to just show the "remaining" part as a tooltip of the filament when one hovers with the mouse, or doing a new label below the existing one. Having said that, I'm extremelly interested in this as I recently looked how to get this output in Cura and failed miserably as it is not part of the "special variables" they have available... |
Yes, I was wondering how this would look, hence the screenshot request. @pedrolamas it may be too much to ask in this PR, maybe we can track in a other issue, but what about a config setting to display either or. And whichever is not displayed, becomes the tooltip on mouse hover? |
I'm ok we add a setting to further configure this, but I still think we should do something on how it currently looks. I would prefer that we either break this into 2 labeled entries or just set the 2nd line as a tooltip. |
@TheTiEr what do you think to our suggestions? One label, with tooltip/mouse hover? The config option can be tracked in another issue. I would lean towards two labels, if it was me (and hide the label we don't have, like originally coded) |
I'm with @eduncan911, 2 labels and hide if it is not available! |
Following up on this topic, I just opened this feature request: Ultimaker/Cura#11343 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tweak to the UI labels as we discussed above. Let us know if you have other suggestions.
IMHO these kinds of features must be implemented to be compatible with all the main slicers and with native values or not implemented. Plus adding an option in the settings to choose which kind of value you want. eg grams/meter/percent (and if you want it) Same thing about the time like that was before. I find very annoying to have a list of value which you don't care about. It's a very niche case, need cura + need a plugin in cura. |
I think this option is the best too. Show the remaining weight if it is available else the needed length in meters. The cherry on the top would be to show the remaining weight and while hovering over it, it will show all other informations, like meters and percent. |
I just confirmed, and Cura works out of the box (no extra plugin required!) |
After a quick check IMO a select list in the settings for the filament unit stay the best solution. That not exclude to have a passover like @eduncan911 suggested. |
add the remaining filament weight in the printer status widget.
This could be helpful if you have to change the spool midprint and keep sure that there is enough material on the spool. This helps with sleepless nights