Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add remaing Filament weight in Printer Status #460

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

TheTiEr
Copy link

@TheTiEr TheTiEr commented Dec 15, 2021

add the remaining filament weight in the printer status widget.

This could be helpful if you have to change the spool midprint and keep sure that there is enough material on the spool. This helps with sleepless nights

Copy link
Contributor

@eduncan911 eduncan911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you post a screenshot of this working?

src/components/widgets/status/StatusTab.vue Outdated Show resolved Hide resolved
src/components/widgets/status/StatusTab.vue Outdated Show resolved Hide resolved
@eduncan911 eduncan911 requested a review from pedrolamas January 25, 2022 22:47
@TheTiEr
Copy link
Author

TheTiEr commented Jan 26, 2022

Fluidd remaining Filament

i have added and changed the code to fit your annotations. Above you can see it working.
I use Cura as Slicer. To work with Cura i had to add a plugin, which i had to write on my own, so the needed weight of the filament is written in the header.

@TheTiEr TheTiEr requested a review from eduncan911 January 26, 2022 10:39
eduncan911
eduncan911 previously approved these changes Jan 26, 2022
Copy link
Contributor

@eduncan911 eduncan911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending @pedrolamas review.

@pedrolamas
Copy link
Member

pedrolamas commented Jan 26, 2022

I'm just checking this now, first comment I have is that personally I'm not very fond of that line break that screws the label alignment on the left as it shows on your screenshot!

I wonder if it wouldn't be more practical to just show the "remaining" part as a tooltip of the filament when one hovers with the mouse, or doing a new label below the existing one.

Having said that, I'm extremelly interested in this as I recently looked how to get this output in Cura and failed miserably as it is not part of the "special variables" they have available...

@eduncan911
Copy link
Contributor

eduncan911 commented Jan 26, 2022

Yes, I was wondering how this would look, hence the screenshot request.

@pedrolamas it may be too much to ask in this PR, maybe we can track in a other issue, but what about a config setting to display either or. And whichever is not displayed, becomes the tooltip on mouse hover?

@pedrolamas
Copy link
Member

I'm ok we add a setting to further configure this, but I still think we should do something on how it currently looks. I would prefer that we either break this into 2 labeled entries or just set the 2nd line as a tooltip.

@eduncan911
Copy link
Contributor

@TheTiEr what do you think to our suggestions?

One label, with tooltip/mouse hover?
Or, two labels?

The config option can be tracked in another issue.

I would lean towards two labels, if it was me (and hide the label we don't have, like originally coded)

@pedrolamas
Copy link
Member

I'm with @eduncan911, 2 labels and hide if it is not available!

@pedrolamas
Copy link
Member

Following up on this topic, I just opened this feature request: Ultimaker/Cura#11343

@eduncan911 eduncan911 dismissed their stale review January 26, 2022 18:25

Addition label changes

Copy link
Contributor

@eduncan911 eduncan911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tweak to the UI labels as we discussed above. Let us know if you have other suggestions.

@eduncan911 eduncan911 added the GH - Waiting for Feedback Waiting for the issuer to reply label Jan 26, 2022
@Biorn1950
Copy link
Contributor

IMHO these kinds of features must be implemented to be compatible with all the main slicers and with native values or not implemented.

Plus adding an option in the settings to choose which kind of value you want. eg grams/meter/percent (and if you want it)

Same thing about the time like that was before. I find very annoying to have a list of value which you don't care about.

It's a very niche case, need cura + need a plugin in cura.

@TheTiEr
Copy link
Author

TheTiEr commented Jan 27, 2022

@TheTiEr what do you think to our suggestions?

One label, with tooltip/mouse hover? Or, two labels?

The config option can be tracked in another issue.

I would lean towards two labels, if it was me (and hide the label we don't have, like originally coded)

I think this option is the best too. Show the remaining weight if it is available else the needed length in meters.

The cherry on the top would be to show the remaining weight and while hovering over it, it will show all other informations, like meters and percent.

@pedrolamas
Copy link
Member

It's a very niche case, need cura + need a plugin in cura.

I just confirmed, and Cura works out of the box (no extra plugin required!)

Ultimaker/Cura#11343 (comment)

@Biorn1950
Copy link
Contributor

Biorn1950 commented Jan 27, 2022

It's a very niche case, need cura + need a plugin in cura.

I just confirmed, and Cura works out of the box (no extra plugin required!)

Ultimaker/Cura#11343 (comment)

After a quick check filament_weight_total is already managed by Moonraker for the main slicers.So effectively it's ok on this point. ( @TheTiEr maybe your slicer is outdated and don't have the lasts placeholders or placeholder have been changed and moonraker need to be updated)

IMO a select list in the settings for the filament unit stay the best solution. That not exclude to have a passover like @eduncan911 suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GH - Waiting for Feedback Waiting for the issuer to reply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants