-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add show hidden option to outputs panel #1209
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Thomas White <[email protected]>
dont think im going to get around to adding the thing to display hidden ones differently but the _ at the start of the name should be enough. i also cant work out what tests are needed for this and cant actually find any existing tests for the ui to see what sort of stuff is being tested. so im marking this as ready. if someone can point me at some existing ui tests or can give me guidance on what should be tested here i will work on that but i will do a new PR for the different look thing |
is there anything else that needs to be done to this before it can be merged? |
Apologies, I just haven't had the time yet to review this, but will try to get that done before next release. |
no problem, just wanted to make sure there wasnt something i needed to do with it |
feat: add show hidden option to outputs panel
adds an option to the outputs panel that lets you show any outputs that have been hidden by putting
_
at the start of their name.i would like to add something that makes it so you can tell the "hidden" ones apart but that seems a bit more complex.
i ran this through the existing test and it passed everything but havnt had a chance to look at writing any new ones for this option
Signed-off-by: Thomas White [email protected]