Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log level for elasticsearch errors input #2818

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mtparet
Copy link

@mtparet mtparet commented Nov 30, 2020

Error level to get logs that failed to be ingested by elasticsearch is currently debug level.

I think there are many cases we want to understand what caused the failure without the flood of all others debug logs.

What do you think ?


Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

Documentation

  • [N/A] Documentation required for this feature

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

PettitWesley
PettitWesley previously approved these changes Nov 30, 2020
@PettitWesley
Copy link
Contributor

@edsiper @mtparet I agree with this patch, the log statement is only enabled if the user turns on trace_error. If a user explicitly opts into more information reported on the plugin, I think they should get this info without enabling system-wide debug.

TBH it would be ideal if we had per plugin log levels instead, but for now I think this patch is a good idea.

@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Oct 26, 2022
@github-actions github-actions bot removed the Stale label Aug 15, 2024
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants