Add starting slash to config path in systemd config #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshitanian
requested review from
edsiper,
fujimotos and
koleini
as code owners
toshitanian
changed the title
toshitanian
force-pushed
the
fix_systemd_config
branch
2 times, most recently
from
33cb1d2 to
7032658
Compare
Signed-off-by: Toshiya Kawasaki <[email protected]>
toshitanian
force-pushed
the
fix_systemd_config
branch
from
7032658 to
ce7c65f
Compare
|
@edsiper Do i have to do any action to this single line change? |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config file path specified in systemd config is set as relative path. It should be intended to be absolute path.
In the upstart config, the path is defined as absolute path. I suppose that the path should be set to as absolute path in systemd config as well.
https://github.com/fluent/fluent-bit/blob/master/init/upstart.in#L10
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Example configuration file for the change
[N/A] Debug log output from testing the change
[N/A] Attached Valgrind output that shows no leaks or memory corruption was found
[N/A] Documentation required for this feature
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.