Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_azure: Add support for resource-context access mode #2184 #2545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

floriankoch
Copy link

@floriankoch floriankoch commented Sep 13, 2020

Add support for the resource-context access mode
https://docs.microsoft.com/en-us/azure/azure-monitor/platform/design-logs-deployment#access-mode)

Fixes #2184


Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
[SERVICE]
    Flush           5
    Daemon          off
    Log_Level       debug

[INPUT]
    Name mem
    Tag  mem

[OUTPUT]
    Name azure
    Match *
    Customer_ID xxxxxx
    Shared_Key  xxxxxx
    Resource_Group test
    Subscription_ID xxxxxx
    Additional_providers providers/Microsoft.OperationalInsights/workspaces/test
  • Debug log output from testing the change
[2020/09/14 07:57:46] [ info] Configuration:
[2020/09/14 07:57:46] [ info]  flush time     | 5.000000 seconds
[2020/09/14 07:57:46] [ info]  grace          | 5 seconds
[2020/09/14 07:57:46] [ info]  daemon         | 0
[2020/09/14 07:57:46] [ info] ___________
[2020/09/14 07:57:46] [ info]  inputs:
[2020/09/14 07:57:46] [ info]      mem
[2020/09/14 07:57:46] [ info] ___________
[2020/09/14 07:57:46] [ info]  filters:
[2020/09/14 07:57:46] [ info] ___________
[2020/09/14 07:57:46] [ info]  outputs:
[2020/09/14 07:57:46] [ info]      azure.0
[2020/09/14 07:57:46] [ info] ___________
[2020/09/14 07:57:46] [ info]  collectors:
[2020/09/14 07:57:46] [ info] [engine] started (pid=16379)
[2020/09/14 07:57:46] [debug] [engine] coroutine stack size: 24576 bytes (24.0K)
[2020/09/14 07:57:46] [debug] [storage] [cio stream] new stream registered: mem.0
[2020/09/14 07:57:46] [ info] [storage] version=1.0.5, initializing...
[2020/09/14 07:57:46] [ info] [storage] in-memory
[2020/09/14 07:57:46] [ info] [storage] normal synchronization mode, checksum disabled, max_chunks_up=128
[2020/09/14 07:57:46] [ info] [output:azure:azure.0] customer_id='xxxxxx' host='xxxxxx.ods.opinsights.azure.com:443'
[2020/09/14 07:57:46] [debug] [router] match rule mem.0:azure.0
[2020/09/14 07:57:46] [ info] [sp] stream processor started
[2020/09/14 07:57:50] [debug] [task] created task=0x5bb4cb93e3e0 id=0 OK
[2020/09/14 07:57:51] [debug] [output:azure:azure.0] resource_id=/resource/subscriptions/xxxxxx/resourcegroups/test/providers/Microsoft.OperationalInsights/workspaces/test
[2020/09/14 07:57:51] [ info] [output:azure:azure.0] customer_id=xxxxxx,
[azure_out_valgrind.log](https://github.com/fluent/fluent-bit/files/5216455/azure_out_valgrind.log)
 HTTP status=200
[2020/09/14 07:57:51] [debug] [upstream] KA connection #19 to xxxxxx.ods.opinsights.azure.com:443 is now available
[2020/09/14 07:57:51] [debug] [task] destroy task=0x5bb4cb93e3e0 (task_id=0)
[2020/09/14 07:57:55] [debug] [task] created task=0x5bb4cba7b1e0 id=0 OK
[2020/09/14 07:57:55] [debug] [upstream] KA connection #19 to xxxxxx.ods.opinsights.azure.com:443 has been assigned (recycled)
[2020/09/14 07:57:55] [debug] [output:azure:azure.0] resource_id=/resource/subscriptions/xxxxxx/resourcegroups/test/providers/Microsoft.OperationalInsights/workspaces/test
[2020/09/14 07:57:55] [ info] [output:azure:azure.0] customer_id=xxxxxx, HTTP status=200
[2020/09/14 07:57:55] [debug] [upstream] KA connection #19 to xxxxxx.ods.opinsights.azure.com:443 is now available
[2020/09/14 07:57:55] [debug] [task] destroy task=0x5bb4cba7b1e0 (task_id=0)
[2020/09/14 07:58:00] [debug] [task] created task=0x5bb4cba7d9e0 id=0 OK
[2020/09/14 07:58:00] [debug] [upstream] KA connection #19 to xxxxxx.ods.opinsights.azure.com:443 has been assigned (recycled)
[2020/09/14 07:58:00] [debug] [output:azure:azure.0] resource_id=/resource/subscriptions/xxxxxx/resourcegroups/test/providers/Microsoft.OperationalInsights/workspaces/test
[2020/09/14 07:58:00] [ info] [output:azure:azure.0] customer_id=xxxxxx, HTTP status=200
[2020/09/14 07:58:00] [debug] [upstream] KA connection #19 to xxxxxx.ods.opinsights.azure.com:443 is now available
[2020/09/14 07:58:00] [debug] [task] destroy task=0x5bb4cba7d9e0 (task_id=0)

Documentation


Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@floriankoch
Copy link
Author

And i need some help to resolve the clang errors

@floriankoch floriankoch force-pushed the out_azure_resource_mode branch from 0d59212 to 3a7dc3e Compare September 14, 2020 10:03
@floriankoch
Copy link
Author

No contribution desired

@edsiper
Copy link
Member

edsiper commented Jan 26, 2021

@floriankoch we apologies for the misunderstanding.

Our team is very overloaded with community requirements and some cloud connectors don't have a former counterpart to validate the changes.

@floriankoch floriankoch reopened this Jan 26, 2021
@edsiper
Copy link
Member

edsiper commented Jan 26, 2021

@floriankoch thanks for re-opening.

side question: would you be interested in to maintain this connector?

@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Mar 23, 2021
@edsiper edsiper removed the Stale label Dec 13, 2021
@edsiper
Copy link
Member

edsiper commented Dec 13, 2021

ping

let's rebase this on top of GIT Master

@edsiper edsiper added the waiting-for-user Waiting for more information, tests or requested changes label Dec 13, 2021
@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Mar 13, 2022
@floriankoch
Copy link
Author

floriankoch commented Jun 21, 2022

@edsiper hi, coming back to this one or better this one #4065 - i want to give this a new try - should we use this PR or #4065 or open a new one?

@github-actions github-actions bot removed the Stale label Jun 23, 2022
@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale waiting-for-user Waiting for more information, tests or requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure add support for x-ms-AzureResourceId Header
2 participants