Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_syslog: add expansion for ident and msg-id in tag #1720

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jiping-s
Copy link
Contributor

@jiping-s jiping-s commented Nov 8, 2019

Allow * in tag, e.g. syslog/*/*/. Wildcard chars are to be expanded to <ident> and <msg-id> fields.

One and only * is expanded to <ident>, and an optional, second * is expanded to <msg-id>.

A test runtime/in_syslog.c has been added to verify the tag expansion functionality - it does not involve any real syslog service.

Signed-off-by: Ji-Ping Shen [email protected]

@jstaffans
Copy link

@edsiper, is this something that could be considered upstream? It would be pretty useful in some cases, given that tag manipulation is not really supported yet by Fluent Bit.

@edsiper
Copy link
Member

edsiper commented May 5, 2020

Sorry for the late reply.

  • please rebase on top of git master
  • re-write the 'fill' function using normal msgpack-c API if needed

@edsiper edsiper self-assigned this May 5, 2020
@edsiper edsiper added the waiting-for-user Waiting for more information, tests or requested changes label May 5, 2020
@bemyak bemyak force-pushed the syslog-enhancements branch from 1e36019 to 061d1cd Compare May 28, 2020 12:51
@bemyak bemyak force-pushed the syslog-enhancements branch from 061d1cd to cfc9049 Compare May 28, 2020 12:55
Allow * in tag, e.g. syslog/*/*/. Wildcard chars are to be expanded to <ident> and <msg-id> fields.

One and only * is expanded to <ident>, and an optional, second * is expanded to <msg-id>.

A test runtime/in_syslog.c has been added to verify the tag expansion functionality - it does not involve any real syslog service.

Signed-off-by: Sergej Gureev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-user Waiting for more information, tests or requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants