Add liquid cooling stats #1247
Open
Add liquid cooling stats #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/liquid.h
Outdated
| std::vector<WatercoolingDevice> devices; | ||
| }; | ||
|
|
||
| extern LiquidStats liquidStats; |
There was a problem hiding this comment.
this should be a unique_ptr
src/overlay_params.cpp
Outdated
| @@ -721,6 +727,8 @@ static void set_param_defaults(struct overlay_params *params){ | |||
| params->table_columns = 3; | |||
| params->text_outline_color = 0x000000; | |||
| params->text_outline_thickness = 1.5; | |||
| params->liquid_color=0x3fcbd4; | |||
There was a problem hiding this comment.
missing spaces before and after =
| @@ -1196,6 +1203,78 @@ void HudElements::device_battery() | |||
| #endif | |||
| } | |||
|
|
|||
| void HudElements::liquid_stats() | |||
There was a problem hiding this comment.
Since liquid is only for unix and we only compile liquid.cpp on unix, the windows compiler does not have access to liquidStats.
set #ifndef _WIN32 inside this function so it's not being compiled with mingw.
This should resolve the failing mingw test
|
Updated to fix mingw build and apply your suggestions |
Makevelli
force-pushed
the
liquid_cooling
branch
from
842ade4
to
e8efb7a
Compare
Makevelli
force-pushed
the
liquid_cooling
branch
from
c7e814a
to
1e13c38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to display sensors data from watercooling devices. It is mainly for Aquacomputer devices since mainline kernel support is available. Support for devices from other manufacturers could be added if there are kernel modules that expose them in sysfs.