-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #56
Update README.md #56
Conversation
FYI @rachaelshaw I took this TODO |
Hey @getvictor unrelated to this PR, what do we use this Fleet GitOps repo in GitLab for? https://gitlab.com/developers6254743/fleet-gitops I was recently invited. |
We need a GitLab repo to test the GitLab CI (.gitlab-ci.yml). It is a mirror of this repo. But we need the URL to be something like https://gitlab.com/fleetdm/fleet-gitops |
@getvictor ah, ok. Will our users ever interact w/ it? Or is the best practice to clone the GitHub repo using GitLab? Wondering b/c, as someone new to GitLab, I'm confused looking at the steps in the README: How do I clone the repo if I'm using GitLab? Do I create a GitLab repo after I clone the GitHUb repo? |
Both GitHub and GitLab use git. So terms like |
@noahtalerman @getvictor I created it: https://gitlab.com/fleetdm/fleet-gitops @getvictor You should have access but let me know if not. |
@getvictor does this mean that any change (commit) in GitHub will be reflected in GitLab and vice versa? @getvictor, the changes in this PR are my pass at simplifying the setup instructions. What do you think? For later: Now that we have a GitHub and GitLab repo, my understanding is that we could simplify the setup steps further by removing these steps: I think we can come back to this later. My understanding is that this would require making changes to the GitHub and GitLab repos and maintaining these repos separately. |
@noahtalerman Commit to GitHub will be reflected in GitLab, but not vice versa. The changes look good. The deletion step 4 is optional, so we could simply remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One comment.
README.md
Outdated
|
||
1. Create your own GitLab repository. | ||
1. Clone the [GitLab repository](https://gitlab.com/fleetdm/fleet-gitops), create your own GitLab repository, and push your clone to your new repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point, the pipeline/action will run and fail because the secrets are not present. We could call it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
he pipeline/action will run and fail because the secrets are not present.
@getvictor only for GitLab right? I added a note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For both (although I haven't tried this updated flow with GitLab)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For both
Added for both.
Ah, ok. If it's quick, do you mind giving the updated instructions a go? Don't want to promote a best practice that we haven't tried ourselves.
Let me know if trying them isn't quick. I can pull the updated instructions out into a separate story that we can address later.
Removed it 👍 |
Decided to merge this. If we learn that the new instructions don't work we can quickly update. |
fleetctl gitops
. Users don't interact w/ it