Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filters in rewrite_options #115

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Conversation

lmt-swallow
Copy link
Member

Description

(WIP)

Checklist

  • I opened a draft PR or added the [WIP] to the title if my PR is not ready for review.
  • I have reviewed the code by myself.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests enough to show how your code behaves and that your code works as expected.

Additional Notes

(WIP)

Signed-off-by: Takashi Yoneuchi <[email protected]>
Signed-off-by: Takashi Yoneuchi <[email protected]>
Signed-off-by: Takashi Yoneuchi <[email protected]>
Signed-off-by: Takashi Yoneuchi <[email protected]>
Signed-off-by: Takashi Yoneuchi <[email protected]>
Signed-off-by: Takashi Yoneuchi <[email protected]>
Signed-off-by: Takashi Yoneuchi <[email protected]>
Signed-off-by: Takashi Yoneuchi <[email protected]>
@lmt-swallow lmt-swallow self-assigned this Nov 1, 2021
@netlify
Copy link

netlify bot commented Nov 1, 2021

✔️ Deploy Preview for cranky-fermi-e6c846 canceled.

🔨 Explore the source changes: 85ef7b4

🔍 Inspect the deploy log: https://app.netlify.com/sites/cranky-fermi-e6c846/deploys/6182e3b7918c1b000753a076

@lmt-swallow lmt-swallow added the type: feature New feature label Nov 1, 2021
Signed-off-by: Takashi Yoneuchi <[email protected]>
Signed-off-by: Takashi Yoneuchi <[email protected]>
Signed-off-by: Takashi Yoneuchi <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #115 (85ef7b4) into main (3ed9086) will decrease coverage by 3.82%.
The diff coverage is 70.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   75.14%   71.32%   -3.83%     
==========================================
  Files          31       35       +4     
  Lines        1718     1984     +266     
==========================================
+ Hits         1291     1415     +124     
- Misses        427      569     +142     
Impacted Files Coverage Δ
src/cli/reporter.rs 0.00% <ø> (ø)
src/cli/reporter/json.rs 0.00% <0.00%> (ø)
src/cli/reporter/sarif.rs 0.00% <0.00%> (ø)
src/cli/subcommand/find.rs 0.00% <0.00%> (ø)
src/core/ruleset/filter.rs 26.47% <26.47%> (ø)
src/core/rewriter/node.rs 31.74% <31.74%> (ø)
src/core/ruleset/util.rs 40.00% <40.00%> (ø)
src/core/rewriter/builder.rs 55.97% <50.00%> (-10.70%) ⬇️
src/core/ruleset/constraint.rs 54.87% <54.87%> (ø)
src/core/matcher/item.rs 64.19% <64.18%> (-21.07%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed9086...85ef7b4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants