Add Qt annotations #1352
Open
Add Qt annotations #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upon trying to actually compile the Qt project, it seems like the arguments named Probably not relevant here though as it's probably something that should be fixed on Qt's side. |
|
The annotations look correct. |
| @@ -74,6 +74,7 @@ | |||
| <method name="OpenURI"> | |||
| <arg type="s" name="parent_window" direction="in"/> | |||
| <arg type="s" name="uri" direction="in"/> | |||
| <annotation name="org.qtproject.QtDBus.QtTypeName.In2" value="QVariantMap"/> | |||
| <arg type="a{sv}" name="options" direction="in"/> | |||
There was a problem hiding this comment.
a{sv} isn't needed to be special cased, which makes up a lot of these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested both by adding all
.xmlinterface files to a Qt project viaqt_add_dbus_interface, and throughmeson test -C _build.Two tests are failing, attached for posterity:
testlog.txt
They don't seem to be introduced by this PR though, as I can still reproduce them on the previous commit, even after a clean rebuild.
Note that
Lockdown.xmlstill errors as its property names arekebab-casedinstead ofsnake_cased, which Qt considers as invalid.Also does minor formatting changes for consistency:
type=beforename=