Handle Boolean attributes (e.g. 'checked', 'selected') #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when trying to bind the 'checked' state of a checkbox, Platesjs will always check the checkbox, regardless of the 'checked' value being provided. This is because Platesjs requires all bound elements to be part of the template and the html spec specifies that Boolean attributes such as 'checked' merely have to be present on the element to perform their function. This PR fixes the issue by effectively removing Boolean attributes from the element in question if the mapped value evaluates to false. For details: http://www.w3.org/TR/html4/intro/sgmltut.html#h-3.3.4.2 kangax/html-minifier#63 (comment)
|
Incidentally, this fixes #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when trying to map the 'checked' state of a checkbox, Platesjs will always check the checkbox, regardless of the 'checked' value being provided. This is because Platesjs requires all mapped elements to be part of the template and the html spec specifies that Boolean attributes such as 'checked' merely have to be present on the element to perform their function.
This simple PR fixes the issue by effectively removing Boolean attributes from the element in question if the mapped value evaluates to false.
For details:
http://www.w3.org/TR/html4/intro/sgmltut.html#h-3.3.4.2
kangax/html-minifier#63 (comment)