An opinionated PR #267
Open
An opinionated PR #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longlho
force-pushed
the
master
branch
2 times, most recently
from
00b1683
to
0ed4bf1
Compare
| }; | ||
|
|
||
| Router.prototype = Object.create(BaseRouter.prototype); |
There was a problem hiding this comment.
This doesn't really look browser friendly to me.
There was a problem hiding this comment.
Object.create is part of ES5 & since we've already used Array.isArray (ES5) in a bunch of places I figure this is safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gulpin particular)browserifyto package browser script, which will exposewindow.Routerautomaticallybrowser.jsinherits fromrouter.jsFor discussions:
vows& browser usesqunit. Any chance of unifying them w/mocha&expect.jsor something? I wanna hook up either browserstack/sauce labs/phantomjs to this to automate build process.Array.isArray), maybe we need some instructions on ES5shim requirements for <IE9 users?