Added purge command for purging a document #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Database.prototype.purge = function(id, rev) { | ||
| var that = this, doc, args = new(Args)(arguments); | ||
| function purge() { |
There was a problem hiding this comment.
Move the purge function to the outer scope, and pass the arguments using function parameters.
|
Document this new API to the readme (and fix the minor issue I commented), after that looks good for merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CouchDB does not remove a document permanently from DB after a remove() command call. A special, purge command must be used. It is not recommended to use daily - should be mainly used for security purposes such as erasing credit card numbers, however in my project I use it so I thought it should be in cradle for the API to be complete