Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime 43 #61

Closed
wants to merge 7 commits into from
Closed

Runtime 43 #61

wants to merge 7 commits into from

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Mar 23, 2023 •
edited
Loading

Closes #60
Closes #41

@flathubbot
Copy link

Started test build 30082

@flathubbot
Copy link

Build 30082 failed

hfiguiere
hfiguiere reviewed Mar 23, 2023
View reviewed changes
org.gnome.Rhythmbox3.json
@@ -43,13 +43,13 @@
{
"name": "grilo",
"buildsystem": "meson",
"config-opts": [ "-Denable-gtk-doc=false", "-Denable-grl-pls=false" ],
"config-opts": [ "-Denable-gtk-doc=false", "-Denable-grl-pls=false", "-Dsoup3=false" ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean true here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But rhythmbox still depends on libsoup-2.4

@hfiguiere
Copy link
Contributor

GNOME 44 is out

Grilo needs to be built with libsoup3.

(and possibly more)

@flathubbot
Copy link

Started test build 30085

@flathubbot
Copy link

Build 30085 failed

@flathubbot
Copy link

Started test build 30087

@flathubbot
Copy link

Build 30087 failed

@flathubbot
Copy link

Started test build 30089

@flathubbot
Copy link

Build 30089 failed

@flathubbot
Copy link

Started test build 30091

@bbhtt bbhtt mentioned this pull request Mar 23, 2023
Open
@flathubbot
Copy link

Build 30091 failed

@hfiguiere
Copy link
Contributor

bot, build

@flathubbot
Copy link

Queued test build for org.gnome.Rhythmbox3.

hfiguiere
hfiguiere reviewed Mar 23, 2023
View reviewed changes
org.gnome.Rhythmbox3.json
@@ -1,7 +1,7 @@
{
"app-id": "org.gnome.Rhythmbox3",
"runtime": "org.gnome.Platform",
"runtime-version": "42",
"runtime-version": "43",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

44 is out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

44 has libsoup3 only no libsoup2

@flathubbot
Copy link

Started test build 30098

@flathubbot
Copy link

Build 30098 failed

@flathubbot
Copy link

Started test build 30099

@flathubbot
Copy link

Build 30099 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/12764/org.gnome.Rhythmbox3.flatpakref

@hfiguiere
Copy link
Contributor

submitted flathub/shared-modules#242 for libsoup-2.4

This was referenced Mar 24, 2023
Merged
Merged
@A6GibKm
Copy link
Contributor

A6GibKm commented Mar 24, 2023

Is the app using soup2 directly? If not the path forward should be to use soup3 on all modules.

@hfiguiere
Copy link
Contributor

yes it does require it. Or get rid of a lot of user functionalities.

@hfiguiere
Copy link
Contributor

See #62

@bbhtt bbhtt closed this Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfiguiere hfiguiere hfiguiere left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update rhythmbox dependencies to more recent versions Consider upgrading runtime org.gnome.Platform version
4 participants
@bbhtt @flathubbot @hfiguiere @A6GibKm