Added greeting_type configuration option (#163) #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a greeting_type configuration option, which can be set to "postfix" or "guerrilla". If the Postfix option is selected, the SMTP greeting message will identify the server as Postfix. If the Guerrilla option is selected, the SMTP greeting message will identify the server as Guerrilla.
Having the ability to change how the server identifies itself is a protection against services that check the greeting message in order to detect and block temp mail services. The "postfix" option is set as default, as this will be the most convenient option for most users.
The tests have been updated to handle this change.
This closes #163 (and, potentially, #221).