Add shortcut for Grab Color #3387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not against the sidebar getting open, but we should gauge user's experience and collect feedback. Regardless, imho this PR in current form is very nice. 👍 Let's let the devs review the PR and then merge. |
|
@AlexP11223 Thank you for the PR. I have only two small nitpicks:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3384, adds a shortcut (default G) for starting color grabbing.
After finishing it opens the side panel even if it was hidden before. I am not sure if there is a simple way to fix that, but it may be the right way to do it anyway, so that you can see what color was actually grabbed.