Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Warning and docs about fullscreen methods outside the mobile platforms #3419

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

erickzanardo
Copy link
Member

@erickzanardo erickzanardo commented Dec 19, 2024

Description

Adds a warning when calling fullScreen and the new added method restoreFullscreen when used in a desktop platform.

Also adds a brief warning to the docs about some methods in the device class not working outside mobile

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@erickzanardo erickzanardo requested a review from a team December 19, 2024 13:04
doc/flame/other/util.md Outdated Show resolved Hide resolved
Co-authored-by: Lukas Klingsbo <[email protected]>
@erickzanardo erickzanardo enabled auto-merge (squash) December 19, 2024 13:16
@erickzanardo erickzanardo merged commit 994e098 into main Dec 19, 2024
8 checks passed
@erickzanardo erickzanardo deleted the feat/windowed branch December 19, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants