fix: problem with diagnosys operations

flamapy · Jul 23, 2024 · 1316162 · 1316162
1 parent fdf3765
commit 1316162
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -55,4 +55,4 @@ jobs:
           pip install pytest==5.4.3
       - name: Running test
         run: |
-          python -m pytest tests/unit_tests/diagnosis_test.py::test_fastdiag_with_configuration
+          python -m pytest
diff --git a/flamapy/metamodels/pysat_diagnosis_metamodel/models/pysat_diagnosis_model.py b/flamapy/metamodels/pysat_diagnosis_metamodel/models/pysat_diagnosis_model.py
@@ -5,6 +5,7 @@
 from flamapy.metamodels.pysat_metamodel.models import PySATModel
 from flamapy.metamodels.fm_metamodel.models.feature_model import Feature
 
+
 class DiagnosisModel(PySATModel):
     """
     This is a new version of the PySATModel class to support the following tasks:
@@ -165,9 +166,11 @@ def _prepare_assumptions_for_kb(self, assumption: List[int], id_assumption: int)
         return id_assumption
 
     def _convert_keys_to_features(self, configuration: 'Configuration') -> 'Configuration':
-        new_elements = {Feature(key) if isinstance(key, str) else key: value for key, value in configuration.elements.items()}
+        new_elements = {Feature(key) if isinstance(key, str)
+                        else key: value for key, value 
+                        in configuration.elements.items()}
         return Configuration(new_elements)
-    
+
     def _prepare_assumptions_for_configuration(self, assumption: List[int],
                                                configuration: Configuration,
                                                id_assumption: int) -> int:
@@ -194,4 +197,4 @@ def _prepare_assumptions_for_configuration(self, assumption: List[int],
 
             id_assumption += 1
 
-        return id_assumption
+        return id_assumption
diff --git a/flamapy/metamodels/pysat_diagnosis_metamodel/transformations/fm_to_diag_pysat.py b/flamapy/metamodels/pysat_diagnosis_metamodel/transformations/fm_to_diag_pysat.py
@@ -1,4 +1,4 @@
-from typing import Any, List
+from typing import Any
 
 from flamapy.metamodels.fm_metamodel.models.feature_model import (
     FeatureModel,
@@ -36,7 +36,6 @@ def add_root(self, feature: Feature) -> None:
     #    for clause in clauses:
     #        self.destination_model.add_clause(clause)
     #    self.destination_model.add_clause_to_map(str(relation), clauses)
-
     def add_relation(self, relation: Relation) -> None:
         if relation.is_mandatory():
             clauses = self._add_mandatory_relation(relation)
@@ -50,7 +49,7 @@ def add_relation(self, relation: Relation) -> None:
             clauses = self._add_constraint_relation(relation)
         self._store_constraint_clauses(clauses)
         self.destination_model.add_clause_to_map(str(relation), clauses)
-    
+
     def add_constraint(self, ctc: Constraint) -> None:
         def get_term_variable(term: Any) -> int:
             negated = False

diff --git a/flamapy/metamodels/pysat_metamodel/operations/pysat_configurations.py b/flamapy/metamodels/pysat_metamodel/operations/pysat_configurations.py
@@ -7,6 +7,7 @@
 from flamapy.metamodels.pysat_metamodel.models.pysat_model import PySATModel
 from flamapy.core.models import VariabilityModel
 
+
 class PySATConfigurations(Configurations):
 
     def __init__(self) -> None: