Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completions/magento: Fixes module aggregation for module related commands #10446

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Apr 17, 2024

  1. completions/magento: Fixes module aggregation for module related comm…

    …mands
    
    Previousely when attempting completion for commands `module:enable`,
    `mmodule:disable` and `module:uninstall` and error would be disaplyed,
    stating that "magento" was not found.
    Upon inspection of the issue in the related completion script it became
    clear that:
    1. The shell command `magento` does not exist as the CLI script of
       Magentoresides under `bin/magento`.
    2. The module aggregation would not work after referncing the
       appropriate CLI command as an undeclared variable was being
       introspected.
    3. Using Magento's CLI command took too long to respond as it has to
       bootstrap the whole Magento stack in order to deliver modules.
    
    Thus the whole aggregation was rewritten to a form that actually works
    and reduces the aggregation to reading the appropriate information
    directly from the configuration file, provided that the file exists and
    PHP is installed.
    jean-bernard-valentaten committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ff26c4a View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. completions/magento: Refactors module aggregation for module related …

    …commmands to not use PHP script
    
    Executing random scripts from fish completion poses a threat to the
    system. While this would indicate that the Magento installation has been
    corrupted, it still is better to not run `app/etc/config.php` to get
    hold of the modules.
    Thus the module aggregation was rewritten to make use od `sed` instead,
    which has the additional benefit of being faster than using PHP.
    jean-bernard-valentaten committed May 3, 2024
    Configuration menu
    Copy the full SHA
    fbf5135 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7fab14b View commit details
    Browse the repository at this point in the history