Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show status/action name instead of id in detailed view. #31

Merged
merged 2 commits into from Jun 4, 2018
Merged

Show status/action name instead of id in detailed view. #31

merged 2 commits into from Jun 4, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 1, 2018

No description provided.

@Schrank Schrank requested a review from therouv June 2, 2018 15:13
@Schrank
Copy link
Member

Schrank commented Jun 2, 2018

@therouv May you have a look? Thanks!

@therouv
Copy link
Member

therouv commented Jun 4, 2018

@Magnus-Crossroads Thank you for your contribution!
Would it be possible that you move the hardcoded strings like "Success" to the translation file? Could you update the pull-request accordingly? After that I'm very happy to merge the PR. Thank you!

@therouv therouv merged commit 77ef813 into firegento:develop Jun 4, 2018
@therouv
Copy link
Member

therouv commented Jun 4, 2018

@MagsSwe Thank you! :)

@ghost
Copy link
Author

ghost commented Jun 4, 2018

@therouv No problem. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therouv therouv Awaiting requested review from therouv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Schrank @therouv