Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor precompiles #1902

Merged
merged 1 commit into from
May 21, 2024
Merged

refactor precompiles #1902

merged 1 commit into from
May 21, 2024

Conversation

0x0ece
Copy link
Contributor

@0x0ece 0x0ece commented May 17, 2024

Refactored precompiles.

Done.

  1. Refactor precompiles to sort-of unify their logic (pending differences imposed by Agave)
  2. Improved support for precompiles in fd_exec_instr_test.c
  3. Test are in solana-conformance / test-vectors. We pass all tests assuming: 1) agave has verify_strict, 2) soft check for result 0 vs err, errors match in most cases but not all. Error vs success always match.

In future PRs.

  1. Properly invoke precompiles, these shouldn't be native programs, but run right after ed25519 sigverify.
  2. Ed25519 implements verify_strict, but in Agave they have verify. We should either implement non-strict verify or change it in Agave.

@0x0ece 0x0ece added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit adbafac May 21, 2024
9 checks passed
@0x0ece 0x0ece deleted the 0x0ece/precompiles branch May 21, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants