Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fdctl: tiles specify their own run loop #1762

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fdctl: tiles specify their own run loop #1762

wants to merge 1 commit into from

Conversation

mmcgee-jump
Copy link
Contributor

No description provided.

@mmcgee-jump mmcgee-jump added this to the Frankendancer milestone May 7, 2024
ptaffet-jump
ptaffet-jump approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@ptaffet-jump ptaffet-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.
As I went through it, I realized that we should probably think a bit more about all the lazy values instead of just using 128*300, but that's neither here nor there.

src/app/fdctl/run/tiles/fd_poh.c
Comment on lines 1721 to 1725
lazy( fd_topo_tile_t * tile ) {
(void)tile;
/* See explanation in fd_pack */

return 128L * 300L;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary now, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptaffet-jump ptaffet-jump ptaffet-jump approved these changes

@lheeger-jump lheeger-jump Awaiting requested review from lheeger-jump

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Frankendancer
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmcgee-jump @ptaffet-jump