Build separate bundle for React Native #309
Conversation
| ) => { | ||
| if ( | ||
| !isReactNative && | ||
| event.nativeEvent && |
There was a problem hiding this comment.
when event.nativeEvent.text is present in non-RN environment (I'm assuming browser target)?
| currentValue: any, | ||
| valueProp: any, | ||
| ) => { | ||
| if (event.nativeEvent) { |
There was a problem hiding this comment.
I've extracted this bit from the previous version of getValue, but it seems wrong to me, I have 0 experience with React Native though, so cant validate it :/
maybe this should be just
const getValue = (event, currentValue, valueProp) => event.nativeEvent.text?
There was a problem hiding this comment.
I also have zero RN experience. Maybe we should find someone who does?
There was a problem hiding this comment.
cc @MichelDiz @rafaelcorreiapoli @geowarin @erickjth @bogdansoare @ibratoev @cosmith @maciejmyslinski @ghoshabhi
I think you guys were using (at least at some point in time) this library in RN. Could you take a look at this PR?
There was a problem hiding this comment.
I've never used react-final-form with react native. I asked my friends who code in react native for help, though.
There was a problem hiding this comment.
Cool! Sorry for pinging you then, I've looked through RN-related topics and pinged everyone who was involved.
|
I have react-final-form working fine in react-native 0.60 on both Android and iOS. |
If you like the change I'll have to adjust the tests - didnt want to do that now, because aint sure if you dig this 馃槈
I'm also unsure if my changes are correct, would love you to look on them and validate it.