Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added "Run as admin" support for AHK files #15417

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented May 16, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Right clicked "AHK" (auto hot key) file and confirmed the run as options were displayed

@hishitetsu
Copy link
Member

Shouldn't we check to see if AutoHotKey is installed and only enable the option when it is?

@yaira2
Copy link
Member Author

yaira2 commented May 17, 2024

Shouldn't we check to see if AutoHotKey is installed and only enable the option when it is?

We could do that but that's more compute power for a niche use case.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I was just asking to be sure. LGTM

@yaira2 yaira2 merged commit af0ab75 into main May 17, 2024
6 checks passed
@yaira2 yaira2 deleted the ya/RunAsForAHK branch May 17, 2024 01:33
@yaira2
Copy link
Member Author

yaira2 commented May 17, 2024

To be clear, it's very little compute power but I don't think it's really needed.

@yaira2 yaira2 added area - actions Features or bug reports relating to actions and removed needs - code review labels May 17, 2024
@hishitetsu
Copy link
Member

Sorry, I didn't test it properly.
"Run as admin" works correctly, but "Run as another user" does not. AHK does not seem to support "Run as another user".

@yaira2
Copy link
Member Author

yaira2 commented May 17, 2024

Can you open an issue to track this? It should be a simple fix on my side.

@hishitetsu
Copy link
Member

Can you open an issue to track this? It should be a simple fix on my side.

#15423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area - actions Features or bug reports relating to actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Run as admin doesn't show on .ahk files
2 participants