Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added support for Listary integration #15069

Merged
merged 3 commits into from Mar 31, 2024
Merged

Feature: Added support for Listary integration #15069

merged 3 commits into from Mar 31, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Mar 27, 2024

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

@0x5bfa
Copy link
Member

0x5bfa commented Mar 28, 2024

Are we gonna create a new repo for this?

@yaira2 yaira2 marked this pull request as draft March 28, 2024 01:27
@yaira2 yaira2 marked this pull request as ready for review March 28, 2024 02:13
@yaira2
Copy link
Member Author

yaira2 commented Mar 28, 2024

@0x5bfa the plugin is available here https://github.com/files-community/Listary.FileAppPlugin.Files.

@yaira2 yaira2 marked this pull request as draft March 28, 2024 02:47
@yaira2 yaira2 marked this pull request as ready for review March 28, 2024 14:07
@yaira2 yaira2 changed the title Feature: Listary integration Feature: Added support for a Listary integration Mar 28, 2024
@yaira2
Copy link
Member Author

yaira2 commented Mar 28, 2024

The integration is working but I found that it breaks when you enable dual pane.

@gaoqiangks
Copy link

@0x5bfa the plugin is available here https://github.com/files-community/Listary.FileAppPlugin.Files.

Will you say more words about how to use it?

@0x5bfa
Copy link
Member

0x5bfa commented Mar 29, 2024

We need a plugin to make Listary work.
It's on docs of Listary.

@hishitetsu
Copy link
Member

The integration is working but I found that it breaks when you enable dual pane.

In what way? The folder is opened in the active pane, so I don't see a problem.

@yaira2
Copy link
Member Author

yaira2 commented Mar 31, 2024

The integration is working but I found that it breaks when you enable dual pane.

In what way? The folder is opened in the active pane, so I don't see a problem.

I already resolved this, it ended up being an issue with the UI automation tool.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me. LGTM

@yaira2 yaira2 changed the title Feature: Added support for a Listary integration Feature: Added support for Listary integration Mar 31, 2024
@yaira2 yaira2 merged commit f3882fb into main Mar 31, 2024
6 checks passed
@yaira2 yaira2 deleted the ya/Listary branch March 31, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: API for third-party applications to get Files tab‘s path
4 participants