Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue with focusing file list using touch #15054

Closed
wants to merge 2 commits into from

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Mar 26, 2024

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Select items
    2. Tapped empty space using touch screen
    3. Confirmed selection is cleared
    4. Confirmed long touch and hold still opens right click menu
    5. Confirmed clicking with mouse clears selection
    6. Confirmed right clicking with mouse clears selection

Screenshots (optional)
Add screenshots here.

@hishitetsu
Copy link
Member

Sometimes it works, but sometimes not.
Also, flicking also deselects the items. It should only be done when tapped.

@yaira2
Copy link
Member Author

yaira2 commented Mar 31, 2024

@hishitetsu instead of handling this from the selection rectangle, would it be more reliable to register a separate tap event for the blank space in each layout?

@hishitetsu
Copy link
Member

Yes, I think it is not a good idea to handle this with PointerPressed events.

@yaira2 yaira2 closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Tapping blank space (via touch screen) doesn't clear selected item
2 participants