Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub: Added ps1 scripts to simplify CI/CD #15030

Merged
merged 27 commits into from Apr 3, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 23, 2024

Summary

As the title.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.

@0x5bfa 0x5bfa changed the title GitHub: Integrate store deployment with GitHub Actions GitHub: Added store deployment to GitHub Actions Mar 23, 2024
@0x5bfa 0x5bfa marked this pull request as draft March 23, 2024 15:29
@0x5bfa 0x5bfa assigned 0x5bfa and unassigned 0x5bfa Mar 26, 2024
@0x5bfa 0x5bfa marked this pull request as ready for review March 26, 2024 04:03
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Mar 31, 2024
@0x5bfa
Copy link
Member Author

0x5bfa commented Apr 2, 2024

I mean I could but it will take a week because I don’t have time much these days. I’m pretty satisfied changes in this PR and this won’t affect on the app codebase.

@0x5bfa
Copy link
Member Author

0x5bfa commented Apr 2, 2024

If I do have write permission I would not have hurdle when I test those for you because if so I can create a branch in this repo and run workflow manually. While developing this function can I have? It reduces many steps you and I have now that are troublesome.

@yaira2
Copy link
Member

yaira2 commented Apr 2, 2024

I mean I could but it will take a week because I don’t have time much these days. I’m pretty satisfied changes in this PR and this won’t affect on the app codebase.

I'm confident as well and I'm ready to merge those changes, but the Store action is definitely not going to work as is so we might as well split the changes into two PRs.

@0x5bfa
Copy link
Member Author

0x5bfa commented Apr 2, 2024

That's true. Thanks, I will do that then.

@0x5bfa 0x5bfa marked this pull request as draft April 3, 2024 09:18
@0x5bfa 0x5bfa changed the title GitHub: Added store deployment to GitHub Actions GitHub: Added ps1 scripts to simplify CI/CD Apr 3, 2024
@0x5bfa 0x5bfa marked this pull request as ready for review April 3, 2024 09:21
@0x5bfa
Copy link
Member Author

0x5bfa commented Apr 3, 2024

Done. Deleted store-related changes and left only scripts.

@0x5bfa 0x5bfa requested a review from yaira2 April 3, 2024 09:28
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added approved and removed changes requested Changes are needed for this pull request labels Apr 3, 2024
@yaira2 yaira2 merged commit bb8031c into files-community:main Apr 3, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/GitHub-AddStorePipeline branch April 3, 2024 15:53
marianalcar pushed a commit to marianalcar/Files that referenced this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants