New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: Reduced usage of Await inside foreach loops #15005
Merged
Merged
Changes from 17 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
1137d19
Change `async void` ForEach loops to Task.WhenAll
gumbarros 2b39496
Remove unnecessary `.ToList()` calls
gumbarros b7e0d5c
Convert places that cannot run concurrently to for each loop.
gumbarros 9c450b5
Merge branch 'main' into await-foreach
gumbarros 34251f4
Revert to Task.WhenAll
gumbarros c5400db
Merge branch 'main' into await-foreach
gumbarros bdfac31
Convert Task.WhenAll to for each loop.
gumbarros 1c76c0a
Merge remote-tracking branch 'gumbarros/await-foreach' into await-for…
gumbarros 468f60e
Use single foreach loop at ShellContextFlyoutHelper.cs
gumbarros cfae7a4
ShellContextFlyoutHelper.cs formatting
gumbarros 13916c5
Merge branch 'main' into await-foreach
gumbarros a8b024c
Removed async Select
gumbarros 3dc6d27
Use Task.WhenAll for both files and folders
gumbarros a5fd62d
Merge branch 'main' into await-foreach
gumbarros b54a066
Merge branch 'main' into await-foreach
gumbarros c66c891
Merge branch 'main' into await-foreach
gumbarros aeaf561
Use foreach instead of Task.WhenAll at OpenAllTaggedActions.cs
gumbarros ff403ed
Update src/Files.App/Actions/Content/Tags/OpenAllTaggedActions.cs
gumbarros d5820b8
Use OpenPathInNewTag for folderPaths
gumbarros 437ac5b
Update src/Files.App/Actions/Content/Tags/OpenAllTaggedActions.cs
gumbarros f39ae34
Update src/Files.App/Actions/Content/Tags/OpenAllTaggedActions.cs
gumbarros 42baa68
Update src/Files.App/Actions/Content/Tags/OpenAllTaggedActions.cs
gumbarros 47ddf8e
Removed curly braces from OpenAllTaggedActions.cs
gumbarros f0dd74e
Merge remote-tracking branch 'gumbarros/await-foreach' into await-for…
gumbarros 1f3114c
Merge branch 'main' into await-foreach
gumbarros 1651ebb
Update OpenAllTaggedActions.cs
gumbarros eb675da
Merge branch 'main' into await-foreach
gumbarros a6a8768
Merge removeTasks in single line.
gumbarros f5588d4
Merge branch 'main' into await-foreach
gumbarros e55255a
Merge branch 'main' into await-foreach
gumbarros f7f2785
Merge branch 'main' into await-foreach
gumbarros 2a3f706
Use `Task.WhenAll` where appropriate
gumbarros 37d4c59
Merge remote-tracking branch 'gumbarros/await-foreach' into await-for…
gumbarros 099d9f9
Update src/Files.App/Actions/Content/Tags/OpenAllTaggedActions.cs
gumbarros c06eb69
Update src/Files.App/Data/Factories/ShellContextFlyoutHelper.cs
gumbarros 3068557
Change to Task.WhenAll
gumbarros 95327d0
Merge remote-tracking branch 'gumbarros/await-foreach' into await-for…
gumbarros a7664e6
Don't wait the removal tasks
gumbarros 9920480
AddItemsToMainMenu asynchronously
gumbarros 175e1ce
Don't await folder removal
gumbarros a62c7e8
Better readability
gumbarros 820294e
Fix comments and use single `Task.WhenAll` for submenu
gumbarros 8c57090
Merge branch 'main' into await-foreach
gumbarros eff7d6a
Move await to the end of the method
gumbarros 8e569e3
Merge remote-tracking branch 'gumbarros/await-foreach' into await-for…
gumbarros File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here look good but I'd like some more time to go over the other files.