Code Quality: Reduced usage of Await inside foreach loops

src/Files.App/Actions/Content/Tags/OpenAllTaggedActions.cs

@@ -38,8 +38,13 @@ public async Task ExecuteAsync()
 
  await Task.WhenAll(files.Select(file 
  => NavigationHelpers.OpenPath(file.path, _pageContext.ShellPage!)));
-
- folders.ForEach(async folder => await NavigationHelpers.OpenPathInNewTab(folder.path, false));
+
+ var openTasks = folders.Select(async folder =>
+ {
+ await NavigationHelpers.OpenPathInNewTab(folder.path, false);
+ });
+
+ await Task.WhenAll(openTasks);
  }
 
  private void Context_PropertyChanged(object? sender, PropertyChangedEventArgs e)

src/Files.App/Data/Factories/ShellContextFlyoutHelper.cs

@@ -359,20 +359,30 @@ async Task InvokeShellMenuItemAsync(ContextMenu contextMenu, object? tag)
  itemContextMenuFlyout.SecondaryCommands.Insert(1, sendToItems.FirstOrDefault());
  }
 
- // Add items to shell submenu
- shellMenuItems.Where(x => x.LoadSubMenuAction is not null).ForEach(async x =>
- {
- await x.LoadSubMenuAction();
 
- if (!UserSettingsService.GeneralSettingsService.MoveShellExtensionsToSubMenu)
+ var itemsWithSubMenu = shellMenuItems.Where(x => x.LoadSubMenuAction is not null);
+
+ await Task.WhenAll(itemsWithSubMenu.Select(x => x.LoadSubMenuAction()));
+
+ if (!UserSettingsService.GeneralSettingsService.MoveShellExtensionsToSubMenu)
+ {
+ foreach (var item in itemsWithSubMenu)
  {
- AddItemsToMainMenu(itemContextMenuFlyout.SecondaryCommands, x);
+ AddItemsToMainMenu(itemContextMenuFlyout.SecondaryCommands, item);
  }
- else if (itemContextMenuFlyout.SecondaryCommands.FirstOrDefault(x => x is AppBarButton appBarButton && (appBarButton.Tag as string) == "ItemOverflow") is AppBarButton overflowItem)
+ }
+ else
+ {
+ var overflowItem = itemContextMenuFlyout.SecondaryCommands.FirstOrDefault(x => x is AppBarButton appBarButton && (appBarButton.Tag as string) == "ItemOverflow") as AppBarButton;
+
+ if (overflowItem != null)
  {
- AddItemsToOverflowMenu(overflowItem, x);
+ foreach (var item in itemsWithSubMenu)
+ {
+ AddItemsToOverflowMenu(overflowItem, item);
+ }
  }
- });
+ }
  }
  catch { }
  }

src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs

@@ -161,11 +161,13 @@ public async Task<ReturnResult> DeleteItemsAsync(IEnumerable<IStorageItemWithPat
 
  if (!permanently && registerHistory)
  App.HistoryWrapper.AddHistory(history);
+
+
+ // Create a list of tasks to remove items from the jump list asynchronously
+ var removeTasks = source.Select(x => jumpListService.RemoveFolderAsync(x.Path));
 
- var itemsDeleted = history?.Source.Count ?? 0;
-
- // Remove items from jump list
- source.ForEach(async x => await jumpListService.RemoveFolderAsync(x.Path));
+ // Await all removal tasks to complete concurrently
+ await Task.WhenAll(removeTasks);
 
  var itemsCount = banner.TotalItemsCount;
 
@@ -476,8 +478,11 @@ public async Task<ReturnResult> MoveItemsAsync(IEnumerable<IStorageItemWithPath>
  App.HistoryWrapper.AddHistory(history);
  }
 
- // Remove items from jump list
- source.ForEach(async x => await jumpListService.RemoveFolderAsync(x.Path));
+ // Create a list of tasks to remove items from the jump list asynchronously
+ var removeTasks = source.Select(x => jumpListService.RemoveFolderAsync(x.Path));
+
+ // Await all removal tasks to complete
+ await Task.WhenAll(removeTasks);
 
  var itemsCount = banner.TotalItemsCount;
 

src/Files.App/Views/Layouts/BaseLayoutPage.cs

@@ -901,21 +901,25 @@ private async Task AddShellMenuItemsAsync(List<ContextMenuFlyoutItemViewModel> s
  }
  }
 
- // Add items to main shell submenu
- mainShellMenuItems.Where(x => x.LoadSubMenuAction is not null).ForEach(async x =>
+ // Filter mainShellMenuItems that have a non-null LoadSubMenuAction
+ var mainItemsWithSubMenu = mainShellMenuItems.Where(x => x.LoadSubMenuAction is not null).ToList();
+
+ // Load main submenus asynchronously
+ await Task.WhenAll(mainItemsWithSubMenu.Select(async x =>
  {
  await x.LoadSubMenuAction();
-
  ShellContextFlyoutFactory.AddItemsToMainMenu(mainItems, x);
- });
+ }));
 
- // Add items to overflow shell submenu
- overflowShellMenuItems.Where(x => x.LoadSubMenuAction is not null).ForEach(async x =>
+ // Filter overflowShellMenuItems that have a non-null LoadSubMenuAction
+ var overflowItemsWithSubMenu = overflowShellMenuItems.Where(x => x.LoadSubMenuAction is not null).ToList();
+
+ // Load overflow submenus asynchronously
+ await Task.WhenAll(overflowItemsWithSubMenu.Select(async x =>
  {
  await x.LoadSubMenuAction();
-
  ShellContextFlyoutFactory.AddItemsToOverflowMenu(overflowItem, x);
- });
+ }));
 
  itemsControl?.Items.OfType<FrameworkElement>().ForEach(item =>
  {