Fix: Fixed ComboBox position shift

[TheChilledBuffalo]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Closes Bug: ComboBox list shift to the right when clicked on #14965

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  1. Open Files Dev build
  2. Click settings button
  3. Go to pages where ComboBox -es are present (General, Appearance, Folders, Layout)
  4. Check the ComboBox -es to see if the changes have been applied

Screenshots (optional)

2024-03-19.12-17-09.mp4

[0x5bfa]

I’m really not a fan of this.

[0x5bfa]

What is this based on? I don’t like this kind of hard coding.

[TheChilledBuffalo]

I tried to dynamically set a width depending on the width of the largest ComboBoxItem but I couldn't. In the end I settled with 240, which seemed reasonable during my testing.

[yaira2]

240 is a bit large, I would aim for 100.

[0x5bfa]

Can't we make a dynamic extension to measure the largest item size and set that width as min width as other context menus do?

[0x5bfa]

If not, 100 sounds good to me

[0x5bfa]

Ofc you can work on it if you want because I do have other tasks in Files.
Are you gonna work on it with Yair's approval?

[TheChilledBuffalo]

I think I will leave this to you. I'm still only getting familiar with the codebase and the current solution seems too complex for me atm.

[0x5bfa]

What do you think? @yaira2
I've made a branch and added an extension for that though I don't know if it works yet.

I'll need to add a dependency property inside of DependencyObject-derived class(the extension class) and add extensions:ComboBoxExtensions.IsKeepWidthEnabled="True".

This will be a similar implementation to alternative row color extensions for ListView comes from WCT 7.x because that extension is also required to be notified of collection change. I assume that the event will be unhooked on unloaded and memory leak won't happen.

[0x5bfa]

@yaira2 here’s the implementation. That easy but seems not working when loaded because ActualWidth is 0 then. There must be a way to fix tho.

main...0x5bfa:5bfa/Feature-KeepComboBoxWidth

[yaira2]

That looks like a neat solution, I think we should move forward with it if that last issue is resolved.

[0x5bfa]

We should’ve discuss this before moving forward but I really appreciate your attitude towards our discussion on this PR.

I wish you would continue contributing in any way in Files. Feel free to work on another ready-to-build issues in the project board, in the future.

Thank you so much for the first time PR in Files repo!

Closing due to a better idea comes up lately. But feel free to comment on a PR I’ll open regarding this issue.

[yaira2]

It's all worth it if it leads to a better solution 🙂