Feature: Add dimensions to hover on image file

[btomblinson]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Closes Feature: Show image resolution on hover information #14975

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  1. Tested the changes and made sure it matched what the native files app shows

Screenshots (optional)

[yaira2]

@btomblinson did you test to make sure the tooltip for non-images works as expected? It might also be worth checking each of the image formats to make sure it works correctly.

[btomblinson]

Yes I tested hovering over non image files and folders, since it’s relying on the existing helper to detect if it’s an image file I figured that would be good, I can test a .jpg too

[btomblinson]

Tested with a .jpg as well

[hishitetsu]

With the current implementation, wouldn't it display properly in a zip file or on an FTP server?

[btomblinson]

With the current implementation, wouldn't it display properly in a zip file or on an FTP server?

It doesn't

[btomblinson]

With the current implementation, wouldn't it display properly in a zip file or on an FTP server?

It doesn't

I just noticed too in the above screenshot there’s a .png below and you can faintly see the dimensions 😉

[hishitetsu]

With the current implementation, wouldn't it display properly in a zip file or on an FTP server?

It doesn't

I just noticed too in the above screenshot there’s a .png below and you can faintly see the dimensions 😉

I mean image files inside an archive. Dimensions shouldn't be displayed if they can't be retrieved.

[hishitetsu]

If there are corrupt image files in a folder, the folder cannot be opened. The procedure is as follows:

1. Create a text file.
2. Change the extension of the file to png.
3. Try to open the folder which contains that file.

[yaira2]

@btomblinson can you take a look at that issue?

[Jay-o-Way]

Small thing

[0x5bfa]

If there are corrupt image files in a folder, the folder cannot be opened. The procedure is as follows:

1. Create a text file.

2. Change the extension of the file to png.

3. Try to open the folder which contains that file.

@btomblinson Can you work on this?

[btomblinson]

I am out of the loop, what is meant by corrupt image? Can I have an example?

[0x5bfa]

He means an invalid image file; for example, it doesn't have data (0 byte) or it has been modified with notepad or something, resulting in corruption.