Fix: Another fix for thumbnails #14936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
commented
Mar 10, 2024
| @@ -1032,6 +1032,11 @@ public async Task LoadExtendedItemPropertiesAsync(ListedItem item) | |||
| BaseStorageFolder matchingStorageFolder = await GetFolderFromPathAsync(item.ItemPath, cts.Token); | |||
| if (matchingStorageFolder is not null) | |||
| { | |||
| cts.Token.ThrowIfCancellationRequested(); | |||
| await LoadThumbnailAsync(item); | |||
There was a problem hiding this comment.
The issue is resolved when we request the thumbnail after executing GetFolderFromPathAsync. However, this causes a new issue where excessive scrolling crashes the app.
hishitetsu
reviewed
Mar 11, 2024
Comment on lines
+1036
to
+1038
| await LoadThumbnailAsync(item); | ||
|
|
||
| cts.Token.ThrowIfCancellationRequested(); |
There was a problem hiding this comment.
Suggested change
| await LoadThumbnailAsync(item); | |
| cts.Token.ThrowIfCancellationRequested(); | |
| _ = LoadThumbnailAsync(item); |
This seems to avoid crashes, but is that still going to solve the issue?
| @@ -1097,16 +1102,15 @@ public async Task LoadExtendedItemPropertiesAsync(ListedItem item) | |||
| SetFileTag(item); | |||
| }); | |||
| } | |||
| else | |||
| else if (UserSettingsService.FoldersSettingsService.ShowThumbnails && item.SyncStatusUI.SyncStatus != CloudDriveSyncStatus.NotSynced && item.SyncStatusUI.SyncStatus != CloudDriveSyncStatus.Unknown) | |||
There was a problem hiding this comment.
Suggested change
| else if (UserSettingsService.FoldersSettingsService.ShowThumbnails && item.SyncStatusUI.SyncStatus != CloudDriveSyncStatus.NotSynced && item.SyncStatusUI.SyncStatus != CloudDriveSyncStatus.Unknown) | |
| else if (item.SyncStatusUI.SyncStatus != CloudDriveSyncStatus.NotSynced && item.SyncStatusUI.SyncStatus != CloudDriveSyncStatus.Unknown) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Closes Bug: Icons take a while to display under heavy load #14817...
Validation
How did you test these changes?
Screenshots (optional)
Add screenshots here.