Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed an issue where video bitrate was displayed in plain text #14932

Merged
merged 2 commits into from Mar 10, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 10, 2024

Summary

image

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Video encode rate not shown correctly #14892
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Go to properties window of a video file
    2. Go to Details tab
    3. See the bitrate is shown in formatted text

Screenshots

None

@0x5bfa 0x5bfa changed the title Fix: Fixed an issue where video bitrate was displayed in plain text. Fix: Fixed an issue where video bitrate was displayed in plain text Mar 10, 2024
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit e8a5c10 into files-community:main Mar 10, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/Fix-VideoBitRateDisplay branch March 10, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Video encode rate not shown correctly
2 participants