Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Remove embedded Package.appinstaller #14908

Merged
merged 1 commit into from Mar 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/deploy-preview.yml
Expand Up @@ -131,6 +131,14 @@ jobs:
shell: bash
run: find $ARTIFACTS_STAGING_DIR -empty -delete

- name: Update appinstaller schema
run: |
$newSchema = "http://schemas.microsoft.com/appx/appinstaller/2018"
$localFilePath = "${{ env.APPX_PACKAGE_DIR }}/Files.Package.appinstaller"
$fileContent = Get-Content $localFilePath
$fileContent = $fileContent.Replace("http://schemas.microsoft.com/appx/appinstaller/2017/2", $newSchema)
$fileContent | Set-Content $localFilePath

- name: Sign files with Azure Code Signing
uses: azure/[email protected]
with:
Expand Down Expand Up @@ -163,7 +171,7 @@ jobs:
- name: logout
run: |
az logout

- name: Upload the packages to GitHub Actions
uses: actions/upload-artifact@v3
with:
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/deploy-stable.yml
Expand Up @@ -131,6 +131,14 @@ jobs:
shell: bash
run: find $ARTIFACTS_STAGING_DIR -empty -delete

- name: Update appinstaller schema
run: |
$newSchema = "http://schemas.microsoft.com/appx/appinstaller/2018"
$localFilePath = "${{ env.APPX_PACKAGE_DIR }}/Files.Package.appinstaller"
$fileContent = Get-Content $localFilePath
$fileContent = $fileContent.Replace("http://schemas.microsoft.com/appx/appinstaller/2017/2", $newSchema)
$fileContent | Set-Content $localFilePath

- name: Sign files with Azure Code Signing
uses: azure/[email protected]
with:
Expand Down
2 changes: 1 addition & 1 deletion src/Files.App (Package)/Files.Package.wapproj
Expand Up @@ -16,6 +16,7 @@
<AppxBundleAutoResourcePackageQualifiers>Scale|DXFeatureLevel</AppxBundleAutoResourcePackageQualifiers>
<AppxDefaultResourceQualifiers>Language=en-US;af;ar;bg;ca;cs-CZ;da;da-DK;de-DE;el;en-GB;es-ES;es-419;fa-IR;fi-FI;fil-PH;fr-FR;he-IL;hi-IN;hu-HU;id-ID;it-IT;ja-JP;ka;ko-KR;lt;lv-LV;nb-NO;nl-NL;or-IN;pl-PL;pt-BR;pt-PT;ro-RO;ru-RU;sk-SK;sv-SE;ta;th-TH;tr-TR;uk-UA;vi;zh-Hans;zh-Hant</AppxDefaultResourceQualifiers>
<UapAppxPackageBuildMode>StoreUpload</UapAppxPackageBuildMode>
<HoursBetweenUpdateChecks>255</HoursBetweenUpdateChecks>
<EntryPointProjectUniqueName>..\Files.App\Files.App.csproj</EntryPointProjectUniqueName>
<AppxBundle>Always</AppxBundle>
</PropertyGroup>
Expand Down Expand Up @@ -94,7 +95,6 @@
<SubType>Designer</SubType>
</AppxManifest>
<Content Include="Assets\AppTiles\Dev\**" />
<Content Include="Package.appinstaller" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\Files.App.Server\Files.App.Server.csproj">
Expand Down
14 changes: 0 additions & 14 deletions src/Files.App (Package)/Package.appinstaller

This file was deleted.