Fix: Fixed an issue with drag and dropping items onto .ahk files

[lunathanael]

Allow .ahk and .py files to be treated as executable files to allow dragging and dropping other files onto them.

This was accomplished by essentially replacing current support for Python to also include AutoHotkey by combining the Script category.

Removed checks for Python/AHK Installed as AHK (and potentially other scripts) does not support version checking. This can be replaced by an alternative method for checking interpreter installation.

Note: AutoHotkey.exe is required to be added to the path, there is currently no check for this.

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Closes Bug: Unable to drag and drop any file onto .ahk files #14430

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  1. Open app ...
  2. Click settings button ...

Screenshots (optional)

[0x5bfa]

Thanks for the first time contribution!

Note: AutoHotkey.exe is required to be added to the path, there is currently no check for this.

Does this mean that execution continues still the app doesn't check if python is installed? If so, is that ok?

[lunathanael]

Thanks for the first time contribution!

Note: AutoHotkey.exe is required to be added to the path, there is currently no check for this.

Does this mean that execution continues still the app doesn't check if python is installed? If so, is that ok?

Yes, the execution will continue.
Correct me if I'm wrong, but when you open a file, it attempts to use the "default" application to do so, and when none is defined it'll prompt for one. For example, if I open a .ahk file without AutoHotkey installed and added to PATH, it'll prompt for a method to open the script, as if you pressed "open with...".

Thank you for clarifying this, just trying out something relatively easy as my first PR, definitely made some mistakes.

[0x5bfa]

Thanks for the explanation!
You chose a right one:)

Don't worry, I will review on my local and approve.

[lunathanael]

Thanks for the explanation! You chose a right one:)

Don't worry, I will review on my local and approve.

Thanks for the encouragement.
I just tested again and I believe that there is no need for AutoHotkey to be in the PATH.
My initial thought seem to be correct.

[0x5bfa]

And I wanna merge this too until the next release. @yaira2
I'll review tonight

[yaira2]

What happens if the target isn't installed?

[lunathanael]

#14895 (comment)

[lunathanael]

Looking back, I think my comment was unclear. There is no requirement for AutoHotkey to be in the PATH. The program will still function as intended. This picture is if AutoHotkey is neither installed nor in the PATH.

[yaira2]

I meant, what happens if Python isn't installed?

[lunathanael]

From my testing, it treats the file as if you would normally try to open a .py without python installed. If no windows default application for opening the file type is defined, it'll prompt for one like the picture suggests. I'm not sure if I understand or have answered your question correctly, I apologize.

[yaira2]

That answers my question, thanks!

[yaira2]

LGTM

[yaira2]

@lunathanael thank you for contributing to Files!