Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed an issue where the setting control margin was misaligned #14839

Merged
merged 2 commits into from Mar 19, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Feb 26, 2024

Summary

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    None

Screenshots

After Before
image image

@0x5bfa 0x5bfa changed the title Fix Fix: Fixed an issue where the setting control margin is bit off Feb 26, 2024
@0x5bfa
Copy link
Member Author

0x5bfa commented Feb 27, 2024

You can notice that the Header position is bit off. so fixed.

@0x5bfa 0x5bfa changed the title Fix: Fixed an issue where the setting control margin is bit off Fix: Fixed an issue where the setting control margin is a bit off Feb 29, 2024
@yaira2 yaira2 force-pushed the main branch 2 times, most recently from edf33f7 to c79b2cb Compare March 10, 2024 02:11
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented Mar 19, 2024

Does this also affect the properties window?

@0x5bfa
Copy link
Member Author

0x5bfa commented Mar 19, 2024

Of course. Also fix that problem in properties windows.

@yaira2 yaira2 merged commit aea0e53 into files-community:main Mar 19, 2024
6 checks passed
@yaira2 yaira2 changed the title Fix: Fixed an issue where the setting control margin is a bit off Fix: Fixed an issue where the setting control margin was misaligned Mar 19, 2024
@0x5bfa 0x5bfa deleted the 5bfa/Fix-SettingsConrolMargins branch March 19, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants