Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where archive size wouldn't update #13507

Closed

Conversation

Mohammed-619
Copy link

@Mohammed-619 Mohammed-619 commented Oct 12, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Archive size is not updated at the creation #11580

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Create an archive with at least one item.
    2. Observe that the size is correctly displayed., you don't need to Refresh the page to see the size correctly displayed.

Screenshots (optional)

@@ -108,6 +109,7 @@ public static async Task CompressArchiveAsync(IArchiveCreator creator)
FileOperationType.Compressed
);
}
await associated.Refresh_Click();
Copy link
Member

@yaira2 yaira2 Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to only update the individual item? Ideally this would be done from the file watcher but I don't think we need to resort to refreshing the tab.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaira2 I would like to give a shot at fixing this issue, and continue from where Mohammed brought it. Could you point me to where the file watcher code is in this repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheChilledBuffalo thank you for reaching out, the file watcher code is in ItemViewModel.cs.

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Oct 20, 2023
@yaira2 yaira2 changed the title Fix Fix: Fixed issue where archive size wouldn't update Oct 20, 2023
@yaira2 yaira2 force-pushed the main branch 5 times, most recently from a827a37 to 20e04d0 Compare November 2, 2023 18:32
@yaira2
Copy link
Member

yaira2 commented Nov 26, 2023

Closing due to inactivity

@yaira2 yaira2 closed this Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Changes are needed for this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Archive size is not updated at the creation
3 participants