Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add HTTP-RSR to daily retrieval stats #440

Merged
merged 19 commits into from
Jan 9, 2025
Merged

feat: Add HTTP-RSR to daily retrieval stats #440

merged 19 commits into from
Jan 9, 2025

Conversation

NikolasHaimerl
Copy link
Contributor

This MR proposes the following changes:

  1. Add successful http retrieval counter to retrieval_stats table
  2. Keep track of successful http retrievals on a daily timeframe
  3. Tests for processing the success of daily http retrievals

@NikolasHaimerl NikolasHaimerl marked this pull request as ready for review January 8, 2025 13:23
@NikolasHaimerl NikolasHaimerl requested a review from bajtos January 8, 2025 13:23
bajtos
bajtos requested changes Jan 8, 2025
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start!

lib/provider-retrieval-result-stats.js Outdated Show resolved Hide resolved
migrations/001.do.retrieval-stats.sql Outdated Show resolved Hide resolved
test/evaluate.js Outdated Show resolved Hide resolved
bajtos
bajtos reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

migrations/021.do.sucessful-http-retrieval-stats.sql Outdated Show resolved Hide resolved
migrations/021.do.sucessful-http-retrieval-stats.sql Outdated Show resolved Hide resolved
bajtos
bajtos approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@NikolasHaimerl NikolasHaimerl merged commit 3ac022a into main Jan 9, 2025
6 checks passed
@NikolasHaimerl NikolasHaimerl deleted the nhaimerl-add-http-rsr-daily branch January 9, 2025 07:09
@NikolasHaimerl NikolasHaimerl mentioned this pull request Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliangruber juliangruber juliangruber left review comments

@bajtos bajtos bajtos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Space Meridian
Status: ✅ done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikolasHaimerl @juliangruber @bajtos