feat: metric for successful http retrievals #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
requested changes
Jan 8, 2025
Co-authored-by: Miroslav Bajtoš <[email protected]>
Co-authored-by: Miroslav Bajtoš <[email protected]>
|
@NikolasHaimerl Please go ahead and land the pull request yourself. Our GitHub Actions CI/CD pipeline will automatically deploy this change to Fly.io. After the current Spark round ends and spark-evaluate finishes the evaluation run, you will see the first new data point in InfluxDB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR proposes the following changes:
Following the definition of this issue the metric is defined as:
In practice a successful http request is defined by its sucess indicated by
Measurement.retrievalResultas well as the protocol being used indicated byMeasurement.protocol.