Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn fil-deal-ingestor into automated service #26

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

pyropy
Copy link
Contributor

@pyropy pyropy commented Dec 27, 2024

  • Adds Dockerfile and refactors run script to support running from docker environment
  • Adds support for posting automatic updates to slack upon finishing deal ingestion
  • Adds documentation on how to deploy fil-deal-ingester into automated scheduled service

Related to #23

- Add dockerfile and fly config
- Refactor run script to support running from docker container
- Update .gitignore and add .dockerignore files
@pyropy pyropy self-assigned this Dec 27, 2024
@bajtos bajtos mentioned this pull request Jan 6, 2025
4 tasks
@juliangruber
Copy link
Member

@pyropy why is this a draft?

@bajtos bajtos self-requested a review January 6, 2025 12:50
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The change looks great at the high level; let's improve a couple of details now.

run.sh Show resolved Hide resolved
run.sh Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Co-authored-by: Miroslav Bajtoš <[email protected]>
@pyropy pyropy marked this pull request as ready for review January 7, 2025 06:29
@pyropy
Copy link
Contributor Author

pyropy commented Jan 7, 2025

@pyropy why is this a draft?

Woops, I think I forgot to switch it from draft. 👀

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
run.sh Outdated Show resolved Hide resolved
@bajtos bajtos requested review from juliangruber and bajtos January 8, 2025 09:10
@bajtos
Copy link
Member

bajtos commented Jan 8, 2025

I need to land this PR to continue my work on #30, so I merged the suggested documentation improvements.

@juliangruber LGTY now?

README.md Outdated Show resolved Hide resolved
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bajtos lgtm!

@bajtos bajtos merged commit 2147b22 into main Jan 8, 2025
@bajtos bajtos deleted the add/automate-deal-ingestion branch January 8, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants