Savings accounts #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the fact that Co-op/Smile html statements for savings accounts are almost identical to those for current accounts, trying to scrape a savings account with the --current switch didn't work. Investigation showed that this is because the account number is scraped by looking for 'Current Account', whereas for savings accounts this should be 'Priv Savings' or 'Savings' or some such name.
I considered passing in an option for savings or current and using all the current code, but I liked the segmentation of code and tests for different types of accounts. Also, the OFX account type for a savings account should be 'SAVINGS' instead of 'CHECKING'. Because of these two changes, and a desire to keep the code logical, if a bit duplicated, I copied the current code, modifying it to make it work with savings.